Better publishing for all aligner indexes #53
Merged
+201
−182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamrtalbot
reviewed
Dec 5, 2024
| @@ -103,19 +103,19 @@ workflow { | |||
|
|
|||
| output { | |||
| 'bowtie1_index' { | |||
| path { meta, index -> { file -> "${meta.species}/${meta.source}/${meta.id}/Sequence/BowtieIndex/" } } | |||
| path { meta, index -> { file -> "${meta.species}/${meta.source}/${meta.id}/Sequence/BowtieIndex/version1.3.1" } } | |||
There was a problem hiding this comment.
Suggested change
| path { meta, index -> { file -> "${meta.species}/${meta.source}/${meta.id}/Sequence/BowtieIndex/version1.3.1" } } | |
| path { meta, index -> { file -> "${meta.species}/${meta.source}/${meta.id}/Sequence/BowtieIndex/1.3.1" } } |
Do we need version? Feels like that extra string doesn't add anything, the number is sufficient.
There was a problem hiding this comment.
agreeing with you, I just kept this for consistency with what is currently on igenomes
adamrtalbot
approved these changes
Dec 5, 2024
|
preparing an alternate PR based on this one, for a more complete Publish path |
edmundmiller
approved these changes
Dec 5, 2024
Can we merge this one so we can see the diff in the second PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR checklist
nf-core pipelines lint).nextflow run . -profile test,docker --outdir <OUTDIR>).nextflow run . -profile debug,test,docker --outdir <OUTDIR>).docs/usage.mdis updated.docs/output.mdis updated.CHANGELOG.mdis updated.README.mdis updated (including new tool citations and authors/contributors).