-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Final publish extended #54
Conversation
I'm thinking it would be better to add source_gff as metadata in the assets. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We should try and pre-populate the source GFF field, rather than using a custom string. That way, we can get the source_gff for free, no user interaction required.
Still, not blocking. This is a nice feature to add later.
meta.source_gff == "unknown" | ||
? "${meta.species}/${meta.source}/${meta.id}/Sequence/Hisat2Index/version2.2.1" | ||
: "${meta.species}/${meta.source}/${meta.id}/Sequence/Hisat2Index/${meta.source_gff}/version2.2.1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In the pipeline, do you add the name of the GFF to the meta map? This way we get this field populated by default:
meta = meta + [ "source_gff": ${gff.simpleName} ]
Complement #53
Idea is:
1 genome build can have more than a single gff.
ie Human GRCh38.
The fasta is the same, but the gff is more and more refined, so the indexes of the aligners that depends on this gff are now stored in a dedicated folder.
Any alternate proposal?
PR checklist
nf-core pipelines lint
).nextflow run . -profile test,docker --outdir <OUTDIR>
).nextflow run . -profile debug,test,docker --outdir <OUTDIR>
).docs/usage.md
is updated.docs/output.md
is updated.CHANGELOG.md
is updated.README.md
is updated (including new tool citations and authors/contributors).