Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Template update for nf-core/tools version 3.1.1 #75

Merged
merged 25 commits into from
Jan 8, 2025
Merged

Template update for nf-core/tools version 3.1.1 #75

merged 25 commits into from
Jan 8, 2025

Conversation

maxulysse
Copy link
Member

PR checklist

  • This comment contains a description of changes (with reason).
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • If necessary, also make a PR on the nf-core/references branch on the nf-core/test-datasets repository.
  • Make sure your code lints (nf-core pipelines lint).
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

maxulysse
maxulysse commented Jan 8, 2025
View reviewed changes
CITATIONS.md Outdated Show resolved Hide resolved
maxulysse
maxulysse commented Jan 8, 2025
View reviewed changes
.github/workflows/ci.yml Outdated Show resolved Hide resolved
maxulysse
maxulysse commented Jan 8, 2025
View reviewed changes
main.nf Outdated Show resolved Hide resolved
maxulysse
maxulysse commented Jan 8, 2025
View reviewed changes
main.nf Outdated Show resolved Hide resolved
maxulysse
maxulysse commented Jan 8, 2025
View reviewed changes
main.nf Outdated Show resolved Hide resolved
maxulysse
maxulysse commented Jan 8, 2025
View reviewed changes
main.nf Outdated Show resolved Hide resolved
maxulysse
maxulysse commented Jan 8, 2025
View reviewed changes
nextflow.config Outdated Show resolved Hide resolved
maxulysse
maxulysse commented Jan 8, 2025
View reviewed changes
nextflow.config Outdated Show resolved Hide resolved
maxulysse
maxulysse commented Jan 8, 2025
View reviewed changes
docs/usage.md Outdated Show resolved Hide resolved
maxulysse
maxulysse commented Jan 8, 2025
View reviewed changes
nextflow.config Outdated Show resolved Hide resolved
maxulysse
maxulysse commented Jan 8, 2025
View reviewed changes
main.nf Outdated Show resolved Hide resolved
maxulysse
maxulysse commented Jan 8, 2025
View reviewed changes
nextflow.config Outdated Show resolved Hide resolved
heuermh
heuermh approved these changes Jan 8, 2025
View reviewed changes
Copy link
Contributor

@heuermh heuermh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few minor nits, otherwise LGTM

.github/CONTRIBUTING.md Outdated Show resolved Hide resolved
README.md Outdated Show resolved Hide resolved
nextflow.config Outdated Show resolved Hide resolved
@maxulysse maxulysse merged commit bf51f05 into dev Jan 8, 2025
9 checks passed
@maxulysse maxulysse deleted the nf-core-template-merge-3.1.1 branch January 9, 2025 11:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@heuermh heuermh heuermh approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@maxulysse @heuermh