Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use original QC values for Deepvariant after BQSR #1733

Draft
wants to merge 6 commits into
base: dev
Choose a base branch
from
+98 −2
Draft

Use original QC values for Deepvariant after BQSR #1733

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
b1f75d1
use original qc values if BQSR was run before DV
FriederikeHanssen Nov 15, 2024
d709949
update changelog
FriederikeHanssen Nov 15, 2024
7bef573
use extra flag
FriederikeHanssen Nov 16, 2024
bbf7a9e
add nftest
FriederikeHanssen Nov 16, 2024
648a670
remove test profile
FriederikeHanssen Nov 16, 2024
7ae5034
adjust argument
FriederikeHanssen Nov 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,6 +41,7 @@ and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0
- [1695](https://github.com/nf-core/sarek/pull/1695) - Fix and update input_schema.json
- [1702](https://github.com/nf-core/sarek/pull/1702) - Update nf-schema tests that were not failing on lenient mode
- [1712](https://github.com/nf-core/sarek/pull/1712) - Fix missing import statements on error messages when starting without samplesheet
- [1733](https://github.com/nf-core/sarek/pull/1733) - Use original quality values if DeepVariant is run on recalibrated data

### Removed

Expand Down
5 changes: 4 additions & 1 deletion conf/modules/deepvariant.config
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,10 @@
process {

withName: 'DEEPVARIANT_RUNDEEPVARIANT' {
ext.args = { params.wes ? "--model_type=WES" : "--model_type=WGS" }
ext.args = [
params.wes ? "--model_type=WES" : "--model_type=WGS" ,
!params.skip_tools.contains("baserecalibrator") ? "--parse_sam_aux_fields --use_original_quality_scores" : ''
].join(' ').trim()
ext.prefix = { meta.num_intervals <= 1 ? "${meta.id}.deepvariant" : "${meta.id}.deepvariant.${intervals.baseName}" }
ext.when = { params.tools && params.tools.split(',').contains('deepvariant') }
publishDir = [
Expand Down
Loading