Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More Fixes in the German translation #48

Merged
merged 3 commits into from
Dec 9, 2024
Merged

Conversation

NoRi2909
Copy link
Contributor

@NoRi2909 NoRi2909 commented Dec 9, 2024

This PR adds some more polish to the German translation using more consistent grammar and shortening a few strings so they better fit the available space.

It also adds the line with "Elevation" that was not present in the German strings compared to English.

This commit adds some more polish to the German translation using more consistent grammar and shortening a few strings so they better fit the available space.
@NoRi2909
Copy link
Contributor Author

NoRi2909 commented Dec 9, 2024

Please have a look at why this fails. Sorry.

@ngocjohn ngocjohn merged commit d1a3bd2 into ngocjohn:main Dec 9, 2024
1 check failed
@ngocjohn ngocjohn added the translations Translations label Dec 9, 2024
@ngocjohn
Copy link
Owner

ngocjohn commented Dec 9, 2024

Hi @NoRi2909 , it's just a rate limit on github actions. PR is fine, I'm adding new translations, thanks!

ngocjohn pushed a commit to pistikas/lunar-phase-card that referenced this pull request Dec 12, 2024
This PR adds some more polish to the German translation using more
consistent grammar and shortening a few strings so they better fit the
available space.

It also adds the line with "Elevation" that was not present in the
German strings compared to English.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
translations Translations
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants