Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable linting #1

Merged
merged 2 commits into from
Jan 13, 2025
Merged

Enable linting #1

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6806832
Enable lint
rajsite Jan 13, 2025
5f070ec
Change files
rajsite Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .eslintrc.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,3 @@
module.exports = {
extends: ["@microsoft/eslint-config-fast-dna", "prettier"],
extends: ["@ni/eslint-config-fast-dna", "prettier"],
};
2 changes: 1 addition & 1 deletion .github/workflows/main.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ jobs:
if-no-files-found: error

# Validate (Lint and Test)
# - run: npm run lint
- run: npm run lint
# - run: npm run test

# Check Changelog
Expand Down
7 changes: 7 additions & 0 deletions change/@ni-fast-colors-f6a2c094-ddbf-4ea5-b7bf-a4ba1acd9503.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "Dev only changes from lint",
"packageName": "@ni/fast-colors",
"email": "[email protected]",
"dependentChangeType": "none"
}
7 changes: 7 additions & 0 deletions change/@ni-fast-element-d656cdbb-03f7-4b1e-9855-1e8face304a9.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "Dev only changes from lint",
"packageName": "@ni/fast-element",
"email": "[email protected]",
"dependentChangeType": "none"
}
7 changes: 7 additions & 0 deletions change/@ni-fast-foundation-2a30a313-fd12-42c3-a832-748b37cc4207.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Minor lint change to remove unused import",
"packageName": "@ni/fast-foundation",
"email": "[email protected]",
"dependentChangeType": "patch"
}
7 changes: 7 additions & 0 deletions change/@ni-fast-react-wrapper-384c6b04-0717-49a5-a986-bff433c3008c.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "Dev only changes from lint",
"packageName": "@ni/fast-react-wrapper",
"email": "[email protected]",
"dependentChangeType": "none"
}
7 changes: 7 additions & 0 deletions change/@ni-fast-web-utilities-043b70b1-a31f-4276-849b-4986788b6e72.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "Dev only changes from lint",
"packageName": "@ni/fast-web-utilities",
"email": "[email protected]",
"dependentChangeType": "none"
}
3 changes: 3 additions & 0 deletions package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,6 +25,9 @@
"scripts": {
"build": "npm run build --workspaces --if-present",
"pack": "npm run pack --workspaces --if-present",
"lint": "npm run lint --workspaces --if-present",
"format": "npm run format --workspaces --if-present",
"test": "npm run test --workspaces --if-present",
"change": "beachball change",
"check": "beachball check --changehint \"Run 'npm run change' to generate a change file\"",
"sync": "beachball sync",
Expand Down
2 changes: 1 addition & 1 deletion packages/utilities/fast-colors/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": ["@microsoft/eslint-config-fast-dna", "prettier"],
"extends": ["@ni/eslint-config-fast-dna", "prettier"],
"rules": {
"@typescript-eslint/no-non-null-assertion": "off",
"import/extensions": [
Expand Down
4 changes: 3 additions & 1 deletion packages/utilities/fast-colors/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,12 +23,14 @@
"scripts": {
"build": "npm run clean:dist && tsc -p ./tsconfig.build.json && npm run doc",
"pack": "npm pack",
"lint": "npm run eslint",
"format": "npm run eslint:fix",
"test": "npm run build:tests && npm run unit-tests",
"build:tests": "npm run clean:dist && tsc -p ./tsconfig.test.json && npm run doc",
"clean:dist": "node ../../../build/clean.js dist",
"doc": "api-extractor run --local",
"prettier": "prettier --config ../../../.prettierrc --write \"**/*.ts\"",
"prettier:diff": "prettier --config ../../../.prettierrc \"**/*.ts\" --list-different",
"test": "npm run build:tests && npm run eslint && npm run unit-tests",
"eslint": "eslint . --ext .ts",
"eslint:fix": "eslint . --ext .ts --fix",
"unit-tests": "mocha",
Expand Down
2 changes: 1 addition & 1 deletion packages/utilities/fast-react-wrapper/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": ["@microsoft/eslint-config-fast-dna", "prettier"],
"extends": ["@ni/eslint-config-fast-dna", "prettier"],
"rules": {
"import/extensions": [
"error",
Expand Down
8 changes: 5 additions & 3 deletions packages/utilities/fast-react-wrapper/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,17 +22,19 @@
"types": "dist/fast-react-wrapper.d.ts",
"unpkg": "dist/fast-react-wrapper.min.js",
"scripts": {
"clean:dist": "node ../../../build/clean.js dist",
"doc": "api-extractor run --local",
"build": "npm run clean:dist && tsc -p ./tsconfig.json && rollup -c && npm run doc",
"pack": "npm pack",
"lint": "npm run eslint",
"format": "npm run eslint:fix",
"test": "npm run test-chrome:verbose",
"clean:dist": "node ../../../build/clean.js dist",
"doc": "api-extractor run --local",
"dev": "tsc -p ./tsconfig.json -w",
"tdd": "npm run dev & npm run test-chrome:watch",
"prettier": "prettier --config ../../../.prettierrc --write \"**/*.ts\"",
"prettier:diff": "prettier --config ../../../.prettierrc \"**/*.ts\" --list-different",
"eslint": "eslint . --ext .ts",
"eslint:fix": "eslint . --ext .ts --fix",
"test": "npm run eslint && npm run test-chrome:verbose",
"test-node": "mocha --reporter min --exit dist/esm/__test__/setup-node.js './dist/esm/**/*.spec.js'",
"test-node:verbose": "mocha --reporter spec --exit dist/esm/__test__/setup-node.js './dist/esm/**/*.spec.js'",
"test-chrome": "karma start karma.conf.cjs --browsers=ChromeHeadlessOpt --single-run --coverage",
Expand Down
2 changes: 1 addition & 1 deletion packages/utilities/fast-web-utilities/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": ["@microsoft/eslint-config-fast-dna", "prettier"],
"extends": ["@ni/eslint-config-fast-dna", "prettier"],
"rules": {
"import/extensions": [
"error",
Expand Down
4 changes: 3 additions & 1 deletion packages/utilities/fast-web-utilities/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,10 +23,12 @@
"scripts": {
"build": "npm run clean:dist && tsc -p ./tsconfig.build.json",
"pack": "npm pack",
"lint": "echo \"TODO: fix eslint execution\"",
"format": "npm run eslint:fix",
"test": "npm run build && npm run test-chrome:verbose",
"clean:dist": "node ../../../build/clean.js dist",
"prettier": "prettier --config ../../../.prettierrc --write \"**/*.ts\"",
"prettier:diff": "prettier --config ../../../.prettierrc \"**/*.ts\" --list-different",
"test": "npm run eslint && npm run build && npm run test-chrome:verbose",
"test-node": "mocha --reporter min --exit dist/esm/__test__/setup-node.js './dist/esm/**/*.spec.js'",
"test-node:verbose": "mocha --reporter spec --exit dist/esm/__test__/setup-node.js './dist/esm/**/*.spec.js'",
"test-chrome": "karma start karma.conf.ts --browsers=ChromeHeadlessOpt --single-run --coverage",
Expand Down
2 changes: 1 addition & 1 deletion packages/web-components/fast-element/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": ["@microsoft/eslint-config-fast-dna", "prettier"],
"extends": ["@ni/eslint-config-fast-dna", "prettier"],
"rules": {
"max-classes-per-file": "off",
"no-case-declarations": "off",
Expand Down
8 changes: 5 additions & 3 deletions packages/web-components/fast-element/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,10 +22,13 @@
"type": "module",
"unpkg": "dist/fast-element.min.js",
"scripts": {
"clean:dist": "node ../../../build/clean.js dist",
"doc": "api-extractor run --local",
"build": "npm run clean:dist && npm run build:tsc && npm run build:rollup && npm run doc",
"pack": "npm pack",
"lint": "npm run eslint",
"format": "npm run eslint:fix",
"test": "npm run test-chrome:verbose",
"clean:dist": "node ../../../build/clean.js dist",
"doc": "api-extractor run --local",
"build:rollup": "rollup -c",
"build:tsc": "tsc -p ./tsconfig.json",
"dev": "tsc -p ./tsconfig.json -w",
Expand All @@ -34,7 +37,6 @@
"prettier:diff": "prettier --config ../../../.prettierrc \"**/*.ts\" --list-different",
"eslint": "eslint . --ext .ts",
"eslint:fix": "eslint . --ext .ts --fix",
"test": "npm run eslint && npm run test-chrome:verbose",
"test-node": "mocha --reporter min --exit dist/esm/__test__/setup-node.js './dist/esm/**/*.spec.js'",
"test-node:verbose": "mocha --reporter spec --exit dist/esm/__test__/setup-node.js './dist/esm/**/*.spec.js'",
"test-chrome": "karma start karma.conf.cjs --browsers=ChromeHeadlessOpt --single-run --coverage",
Expand Down
2 changes: 1 addition & 1 deletion packages/web-components/fast-foundation/.eslintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
{
"extends": ["@microsoft/eslint-config-fast-dna", "prettier"],
"extends": ["@ni/eslint-config-fast-dna", "prettier"],
"rules": {
"@typescript-eslint/class-name-casing": "off",
"@typescript-eslint/naming-convention": [
Expand Down
8 changes: 5 additions & 3 deletions packages/web-components/fast-foundation/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,20 +22,22 @@
"unpkg": "dist/fast-foundation.min.js",
"type": "module",
"scripts": {
"build": "npm run clean:dist && npm run build:tsc && npm run build:rollup && npm run doc",
"pack": "npm pack",
"lint": "npm run eslint",
"format": "npm run eslint:fix",
"test": "npm run test-chrome:verbose",
"clean:dist": "node ../../../build/clean.js dist",
"doc": "api-extractor run --local",
"build:rollup": "rollup -c",
"build:tsc": "tsc -p ./tsconfig.json",
"build": "npm run clean:dist && npm run build:tsc && npm run build:rollup && npm run doc",
"pack": "npm pack",
"dev": "tsc -p ./tsconfig.json -w",
"tdd": "npm run dev & npm run test-chrome:watch",
"tdd:firefox": "npm run dev & npm run test-firefox:watch",
"prettier": "prettier --config ../../../.prettierrc --write \"**/*.ts\"",
"prettier:diff": "prettier --config ../../../.prettierrc \"**/*.ts\" --list-different",
"eslint": "eslint . --ext .ts",
"eslint:fix": "eslint . --ext .ts --fix",
"test": "npm run eslint && npm run test-chrome:verbose",
"test-node": "mocha --reporter min --exit dist/esm/__test__/setup-node.js './dist/esm/**/*.spec.js'",
"test-node:verbose": "mocha --reporter spec --exit dist/esm/__test__/setup-node.js './dist/esm/**/*.spec.js'",
"test-chrome": "karma start karma.conf.cjs --browsers=ChromeHeadlessOpt --single-run --coverage",
Expand Down
1 change: 0 additions & 1 deletion packages/web-components/fast-foundation/src/tabs/tabs.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@ import {
keyHome,
limit,
uniqueId,
wrapInBounds,
} from "@ni/fast-web-utilities";
import { StartEnd, StartEndOptions } from "../patterns/start-end.js";
import { applyMixins } from "../utilities/apply-mixins.js";
Expand Down