Added GCP supplemental values file #237
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rbell517
reviewed
Dec 11, 2024
getting-started/templates/Openshift-GCP/os_gcp_supplemental_values.yaml
Outdated
Show resolved
Hide resolved
rbell517
reviewed
Dec 11, 2024
getting-started/templates/Openshift-GCP/os_gcp_supplemental_values.yaml
Outdated
Show resolved
Hide resolved
rbell517
reviewed
Dec 11, 2024
getting-started/templates/Openshift-GCP/os_gcp_supplemental_values.yaml
Outdated
Show resolved
Hide resolved
SSSantosh18
reviewed
Dec 13, 2024
getting-started/templates/GCP/Openshift/openshift_supplemental_values.yaml
Outdated
Show resolved
Hide resolved
jayabal-EMR
reviewed
Dec 16, 2024
getting-started/templates/GCP/Openshift/openshift_supplemental_values.yaml
Outdated
Show resolved
Hide resolved
getting-started/templates/GCP/Openshift/openshift_supplemental_values.yaml
Outdated
Show resolved
Hide resolved
added 2 commits
December 16, 2024 18:51
jayabal-EMR
reviewed
Dec 17, 2024
getting-started/templates/OpenShift/openshift_supplemental_values.yaml
Outdated
Show resolved
Hide resolved
jayabal-EMR
approved these changes
Dec 17, 2024
SSSantosh18
requested changes
Dec 18, 2024
SSSantosh18
requested changes
Dec 19, 2024
SSSantosh18
requested changes
Jan 8, 2025
getting-started/templates/OpenShift/openshift_supplemental_values.yaml
Outdated
Show resolved
Hide resolved
priyadarshini-ni
changed the title
SSSantosh18
approved these changes
Jan 10, 2025
priyadarshini-ni
requested review from
JD-Robertson,
prestwick,
BKnight760,
lnowotny,
Christian-Nunnally and
MelissaHilliard
as code owners
JD-Robertson
approved these changes
Jan 10, 2025
| - name: cloud-sql-auth-proxy | ||
| image: gcr.io/cloud-sql-connectors/cloud-sql-proxy:<tag> # <ATTENTION> - Enter the latest version of the Cloud SQL Auth Proxy image | ||
| volumeMounts: | ||
| # This volume mount is required for the proxy to authenticate with Cloud SQL using Workload Identity Federation by providing a short-lived token for authentication. |
There was a problem hiding this comment.
Please be consistent about using parameter markup and ## vs. #. We may start auto-generating wikis from these files in the near future.
There was a problem hiding this comment.
The format for comments have been made consistent based on systemlink-values.yaml.
# has been used for Attention comments and ## for multi-line comments
SSSantosh18
reviewed
Jan 23, 2025
| user: <username> # <ATTENTION> - Enter the PostgreSQL username for the testmonitor service | ||
| ## @param database.connectionInfo.secretName The name of an existing secret with PostgreSQL connection credentials | ||
| ## | ||
| secretName: <secret-name> # <ATTENTION> - Enter the secret name that contains the testmonitor service's Postgres SQL database connection credentials |
There was a problem hiding this comment.
There should be a default value here. Please check this
@priyadarshini-ni Update for all services
There was a problem hiding this comment.
Modified to default value for tm and dff
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
The supplemental values for GCP has been added with examples for GCS Storage and adding cloud SQL auth proxy container.
Note: GCS support is not yet added to dataframe service as the service uses S3 DeleteObjects API which is not supported by GCS S3 interoperable XML API, refer this for more information. The respective documentation for the dataframe service will be updated once we add this support.
Why should this Pull Request be merged?
This acts as an additional values file while SLE is installed in Openshift cluster or GKE cluster on GCP
What testing has been done?
NA