-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix invalid test default values and allow double/float parameters take integers #832
Conversation
Test Results 30 files ± 0 30 suites ±0 40m 39s ⏱️ - 3m 0s Results for commit 5d24d44. ± Comparison against base commit f4043fe. This pull request removes 16 and adds 18 tests. Note that renamed tests count towards both.
♻️ This comment has been updated with latest results. |
packages/service/ni_measurement_plugin_sdk_service/_internal/parameter/_get_type.py
Outdated
Show resolved
Hide resolved
packages/service/ni_measurement_plugin_sdk_service/_internal/parameter/_get_type.py
Outdated
Show resolved
Hide resolved
packages/service/ni_measurement_plugin_sdk_service/_internal/parameter/_get_type.py
Outdated
Show resolved
Hide resolved
packages/service/ni_measurement_plugin_sdk_service/_internal/parameter/_get_type.py
Outdated
Show resolved
Hide resolved
…lists better, fixed formatting
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good except for the empty-array case
What does this Pull Request accomplish?
Resolve issue#824 and issue#825.
Why should this Pull Request be merged?
Fix bugs from PR#807.
What testing has been done?
Ran all the tests and checks locally.