Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid test default values and allow double/float parameters take integers #832

Merged
merged 4 commits into from
Aug 8, 2024

Conversation

LazeringDeath
Copy link
Contributor

What does this Pull Request accomplish?

Resolve issue#824 and issue#825.

Why should this Pull Request be merged?

Fix bugs from PR#807.

What testing has been done?

Ran all the tests and checks locally.

Copy link

github-actions bot commented Aug 6, 2024

Test Results

    30 files  ± 0      30 suites  ±0   40m 39s ⏱️ - 3m 0s
   648 tests + 2     648 ✅ + 2      0 💤 ±0  0 ❌ ±0 
16 060 runs  +60  14 990 ✅ +60  1 070 💤 ±0  0 ❌ ±0 

Results for commit 5d24d44. ± Comparison against base commit f4043fe.

This pull request removes 16 and adds 18 tests. Note that renamed tests count towards both.
tests.unit.test_metadata ‑ test___default_value_different_from_type___validate___raises_type_exception[DataType.Double-1-annotations6]
tests.unit.test_metadata ‑ test___default_value_different_from_type___validate___raises_type_exception[DataType.Enum-1.0-annotations7]
tests.unit.test_metadata ‑ test___default_value_different_from_type___validate___raises_type_exception[DataType.Enum-DifferentColor.TEAL-annotations8]
tests.unit.test_metadata ‑ test___default_value_different_from_type___validate___raises_type_exception[DataType.EnumArray1D-1-annotations9]
tests.unit.test_metadata ‑ test___default_value_different_from_type___validate___raises_type_exception[DataType.EnumArray1D-default_value10-annotations10]
tests.unit.test_metadata ‑ test___default_value_same_as_type___validate___raises_no_exception[DataType.Enum-2-annotations7]
tests.unit.test_metadata ‑ test___default_value_same_as_type___validate___raises_no_exception[DataType.Enum-Color.BLUE-annotations5]
tests.unit.test_metadata ‑ test___default_value_same_as_type___validate___raises_no_exception[DataType.Enum-Countries.AUSTRALIA-annotations7]
tests.unit.test_metadata ‑ test___default_value_same_as_type___validate___raises_no_exception[DataType.EnumArray1D-default_value6-annotations6]
tests.unit.test_service ‑ test___measurement_service___add_configuration__configuration_added[Double1DArray-DataType.DoubleArray1D-default_value4]
…
tests.unit.test_metadata ‑ test___default_value_different_from_type___validate___raises_type_exception[DataType.Enum-1.0-annotations6]
tests.unit.test_metadata ‑ test___default_value_different_from_type___validate___raises_type_exception[DataType.Enum-DifferentColor.TEAL-annotations7]
tests.unit.test_metadata ‑ test___default_value_different_from_type___validate___raises_type_exception[DataType.EnumArray1D-1-annotations8]
tests.unit.test_metadata ‑ test___default_value_different_from_type___validate___raises_type_exception[DataType.EnumArray1D-default_value9-annotations9]
tests.unit.test_metadata ‑ test___default_value_same_as_type___validate___raises_no_exception[DataType.Double-1-annotations5]
tests.unit.test_metadata ‑ test___default_value_same_as_type___validate___raises_no_exception[DataType.DoubleArray1D-default_value6-annotations6]
tests.unit.test_metadata ‑ test___default_value_same_as_type___validate___raises_no_exception[DataType.Enum-2-annotations9]
tests.unit.test_metadata ‑ test___default_value_same_as_type___validate___raises_no_exception[DataType.Enum-Color.BLUE-annotations7]
tests.unit.test_metadata ‑ test___default_value_same_as_type___validate___raises_no_exception[DataType.Enum-Countries.AUSTRALIA-annotations9]
tests.unit.test_metadata ‑ test___default_value_same_as_type___validate___raises_no_exception[DataType.EnumArray1D-default_value10-annotations10]
…

♻️ This comment has been updated with latest results.

@LazeringDeath LazeringDeath marked this pull request as ready for review August 6, 2024 18:36
@LazeringDeath LazeringDeath changed the title [DRAFT] Fix invalid test default values and allow double/float parameters take integers Fix invalid test default values and allow double/float parameters take integers Aug 6, 2024
Copy link
Collaborator

@bkeryan bkeryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good except for the empty-array case

@LazeringDeath LazeringDeath merged commit 962a5af into main Aug 8, 2024
17 checks passed
@dixonjoel dixonjoel deleted the users/tynguyen/default_values branch September 17, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants