Skip to content

Commit

Permalink
NPM Dependency Updates January 2025 (#2504)
Browse files Browse the repository at this point in the history
# Pull Request

## 🀨 Rationale

Follow-up from #2501 and
#2499

## πŸ‘©β€πŸ’» Implementation

- Updated the major dependencies covered in the above mentioned PR
- Did not pull-in React 19 updates yet, seems supported in storybook,
will give it a try in a follow-on PR or create a tech debt:
storybookjs/storybook#29805
- Rebuilt the lock file to pull in latest versions in semver range
- Had to make peerDependencies on React 18 types as the v19 types got
pulled in on rebuild of lock file and caused issues in mdx typing (the
JSX namespace was deprecated in React 18 and removed in React 19):
     ```
Error: ../../node_modules/@types/mdx/types.d.ts(23,38): error TS2503:
Cannot find namespace 'JSX'.
Error:
../../node_modules/@types/mdx/types.d.ts([28](https://github.com/ni/nimble/actions/runs/12565897794/job/35030682905#step:12:29),23):
error TS2503: Cannot find namespace 'JSX'.
Error: ../../node_modules/@types/mdx/types.d.ts(47,28): error TS2503:
Cannot find namespace 'JSX'.
Error: ../../node_modules/@types/mdx/types.d.ts(73,46): error TS2503:
Cannot find namespace 'JSX'.
     ```
- Removed the webpack-cli dep which seems unused (we don't see to use
the command in any scripts)

## πŸ§ͺ Testing

Rely on CI

## βœ… Checklist

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.
  • Loading branch information
rajsite authored Jan 2, 2025
1 parent f2d782c commit 0ca6cc0
Show file tree
Hide file tree
Showing 8 changed files with 1,537 additions and 1,468 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Update to rollup all-components build dependencies",
"packageName": "@ni/nimble-components",
"email": "[email protected]",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Update to rollup all-components build dependencies",
"packageName": "@ni/spright-components",
"email": "[email protected]",
"dependentChangeType": "none"
}
2,974 changes: 1,515 additions & 1,459 deletions package-lock.json

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion packages/angular-workspace/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@
"@ni/eslint-config-angular": "^8.0.0",
"@ni/jasmine-parameterized": "*",
"@ni/nimble-tokens": "*",
"@rollup/plugin-node-resolve": "^15.0.1",
"@rollup/plugin-node-resolve": "^16.0.0",
"@types/jasmine": "^5.1.4",
"@types/node": ">18",
"jasmine-core": "^5.1.2",
Expand Down
2 changes: 1 addition & 1 deletion packages/blazor-workspace/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@
"@ni/nimble-components": "*",
"@ni/nimble-tokens": "*",
"@ni/spright-components": "*",
"@rollup/plugin-node-resolve": "^15.0.1",
"@rollup/plugin-node-resolve": "^16.0.0",
"cross-env": "^7.0.3",
"glob": "^11.0.0",
"playwright": "1.44.0",
Expand Down
3 changes: 1 addition & 2 deletions packages/nimble-components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -104,7 +104,7 @@
"@ni-private/eslint-config-nimble": "*",
"@ni/jasmine-parameterized": "^1.0.0",
"@rollup/plugin-commonjs": "^28.0.0",
"@rollup/plugin-node-resolve": "^15.0.1",
"@rollup/plugin-node-resolve": "^16.0.0",
"@rollup/plugin-replace": "^6.0.0",
"@rollup/plugin-terser": "^0.4.0",
"@types/jasmine": "^5.1.4",
Expand Down Expand Up @@ -132,7 +132,6 @@
"terser-webpack-plugin": "^5.3.10",
"typescript": "~5.4.5",
"webpack": "^5.75.0",
"webpack-cli": "^5.0.1",
"webpack-dev-middleware": "^7.0.0"
}
}
3 changes: 1 addition & 2 deletions packages/spright-components/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -57,7 +57,7 @@
"@ni/jasmine-parameterized": "^1.0.0",
"@ni-private/eslint-config-nimble": "*",
"@rollup/plugin-commonjs": "^28.0.0",
"@rollup/plugin-node-resolve": "^15.0.1",
"@rollup/plugin-node-resolve": "^16.0.0",
"@rollup/plugin-replace": "^6.0.0",
"@rollup/plugin-terser": "^0.4.0",
"@types/jasmine": "^5.1.4",
Expand All @@ -82,7 +82,6 @@
"source-map-loader": "^5.0.0",
"typescript": "~5.4.5",
"webpack": "^5.75.0",
"webpack-cli": "^5.0.1",
"webpack-dev-middleware": "^7.0.0"
}
}
7 changes: 4 additions & 3 deletions packages/storybook/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,14 +26,14 @@
"@ni/nimble-components": "*",
"@ni/nimble-tokens": "*",
"@ni/spright-components": "*",
"@rollup/plugin-node-resolve": "^15.0.1",
"@rollup/plugin-node-resolve": "^16.0.0",
"@storybook/addon-a11y": "^8.4.3",
"@storybook/addon-actions": "^8.4.3",
"@storybook/addon-docs": "^8.4.3",
"@storybook/addon-essentials": "^8.4.3",
"@storybook/addon-interactions": "^8.4.3",
"@storybook/addon-links": "^8.4.3",
"@storybook/addon-webpack5-compiler-swc": "^1.0.5",
"@storybook/addon-webpack5-compiler-swc": "^2.0.0",
"@storybook/cli": "^8.4.3",
"@storybook/csf": "^0.1.11",
"@storybook/html": "^8.4.3",
Expand All @@ -55,6 +55,7 @@
},
"peerDependencies": {
"eslint-plugin-storybook": "^0.11.0",
"react": "^18.3.1"
"react": "^18.3.1",
"@types/react": "^18"
}
}

0 comments on commit 0ca6cc0

Please sign in to comment.