Skip to content

Commit

Permalink
Disable failing tests in Firefox (#2489)
Browse files Browse the repository at this point in the history
# Pull Request

## 🀨 Rationale

Disabling tests that I saw failing on an unrelated pipeline

Issues have been created to track these failing tests: #2488, #2490,
#2491

## πŸ‘©β€πŸ’» Implementation

N/A

## πŸ§ͺ Testing

N/A

## βœ… Checklist

<!--- Review the list and put an x in the boxes that apply or ~~strike
through~~ around items that don't (along with an explanation). -->

- [ ] I have updated the project documentation to reflect my changes or
determined no changes are needed.

---------

Co-authored-by: Jesse Attas <[email protected]>
  • Loading branch information
mollykreis and jattasNI authored Dec 11, 2024
1 parent 9f55b5c commit 1752793
Show file tree
Hide file tree
Showing 4 changed files with 21 additions and 7 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "none",
"comment": "Disable failing tests in Firefox",
"packageName": "@ni/nimble-components",
"email": "[email protected]",
"dependentChangeType": "none"
}
Original file line number Diff line number Diff line change
Expand Up @@ -337,7 +337,8 @@ Plain text 3`);
<user:1> `);
});

it('Mention node', async () => {
// Firefox skipped, see https://github.com/ni/nimble/issues/2488
it('Mention node #SkipFirefox', async () => {
await appendUserMentionConfiguration(element, [
{ key: 'user:1', displayName: 'username1' }
]);
Expand All @@ -347,7 +348,8 @@ Plain text 3`);
expect(element.getMarkdown()).toEqual('<user:1> ');
});

it('Multiple Mention node of same type', async () => {
// Firefox skipped, see https://github.com/ni/nimble/issues/2488
it('Multiple Mention node of same type #SkipFirefox', async () => {
await appendUserMentionConfiguration(element, [
{ key: 'user:1', displayName: 'username1' },
{ key: 'user:2', displayName: 'username2' }
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,8 @@ describe('TableColumnDurationText', () => {
expect(tablePageObject.getCellTitle(0, 0)).toEqual('');
});

it('removes title on mouseout of cell', async () => {
// Firefox skipped, see https://github.com/ni/nimble/issues/2490
it('removes title on mouseout of cell #SkipFirefox', async () => {
table.style.width = '100px';
await table.setData([{ field: 8607022000 }]);
await waitForUpdatesAsync();
Expand All @@ -161,7 +162,8 @@ describe('TableColumnDurationText', () => {
);
});

it('updates displayed date when lang token changes', async () => {
// Firefox skipped, see https://github.com/ni/nimble/issues/2490
it('updates displayed date when lang token changes #SkipFirefox', async () => {
await table.setData([{ field: 8607022000 }]);
await waitForUpdatesAsync();
expect(tablePageObject.getRenderedCellTextContent(0, 0)).toBe(
Expand Down
9 changes: 6 additions & 3 deletions packages/nimble-components/src/table/tests/table.spec.ts
Original file line number Diff line number Diff line change
Expand Up @@ -2620,7 +2620,8 @@ describe('Table', () => {
await waitForUpdatesAsync();
}

it('maintains scroll position if data does not change', async () => {
// Firefox skipped, see https://github.com/ni/nimble/issues/2491
it('maintains scroll position if data does not change #SkipFirefox', async () => {
await setDataAndScrollToBottom(largeData200);
const scrollTopBeforeDisconnect = element.viewport.scrollTop;
const firstRenderedRowBeforeDisconnect = getFirstRenderedRowDataIndex(largeData200);
Expand All @@ -2634,7 +2635,8 @@ describe('Table', () => {
);
});

it('updates scroll position if data length is reduced while not attached', async () => {
// Firefox skipped, see https://github.com/ni/nimble/issues/2491
it('updates scroll position if data length is reduced while not attached #SkipFirefox', async () => {
await setDataAndScrollToBottom(largeData400);
const scrollTopBeforeDisconnect = element.viewport.scrollTop;
const firstRenderedRowBeforeDisconnect = getFirstRenderedRowDataIndex(largeData400);
Expand Down Expand Up @@ -2689,7 +2691,8 @@ describe('Table', () => {
);
});

it('adjusts the number of rendered rows when the table height decreases while not attached', async () => {
// Firefox skipped, see https://github.com/ni/nimble/issues/2491
it('adjusts the number of rendered rows when the table height decreases while not attached #SkipFirefox', async () => {
element.style.height = '500px';
await element.setData(largeData200);
await waitForUpdatesAsync();
Expand Down

0 comments on commit 1752793

Please sign in to comment.