Skip to content

Commit

Permalink
Replace deprectated importsNotUsedAsValues option with `verbatimMod…
Browse files Browse the repository at this point in the history
…uleSyntax` (#2512)

# Pull Request

## 🤨 Rationale

The
[`importsNotUsedAsValues`](https://www.typescriptlang.org/tsconfig/#importsNotUsedAsValues)
TypeScript option is deprectated and will stop working in TypeScript
5.5. It is replaced by
[`verbatimModuleSyntax`](https://www.typescriptlang.org/tsconfig/#verbatimModuleSyntax).

My motivation for this change is that while updating Nimble to Angular
18, I found that `importsNotUsedAsValues` was forcing me to do a
type-only import of `Router` and `ActivatedRoute` [in
`router_link.ts`](https://github.com/ni/nimble/blob/a7927039f1da96ac4672c5550d6b8f55071f125d/packages/angular-workspace/nimble-angular/src/thirdparty/directives/router_link.ts#L39).
But doing so caused a different error for
`NimbleAnchorRouterLinkWithHrefDirective`:

```
error NG2016: The directive NimbleAnchorRouterLinkWithHrefDirective inherits its constructor from RouterLink, but the latter has a constructor parameter that is not compatible with dependency injection. Either add an explicit constructor to NimbleAnchorRouterLinkWithHrefDirective or change RouterLink's constructor to use parameters that are valid for DI.
```

Both `Router` and `ActivatedRoute` are parameters to the `RouterLink`
constructor. The problem is that if we do a type-only import of `Router`
and `ActivatedRoute`, the compiler doesn't know that they are decorated
to be injectable. Using `verbatimModuleSyntax` solves this by allowing
us to import from the definition file rather than the type declaration
file for those types, even though we're not directly using the
definition.

This PR changes the option for the Angular projects, as well as
`nimble-components`, `spright-components`, and `storybook`.

## 👩‍💻 Implementation

Had to update all imports of type symbols to explicitly say `type`.

## 🧪 Testing

Builds and existing tests pass.

## ✅ Checklist

- [x] I have updated the project documentation to reflect my changes or
determined no changes are needed.

---------

Co-authored-by: Milan Raj <[email protected]>
  • Loading branch information
m-akinc and rajsite authored Jan 16, 2025
1 parent 7e46f34 commit 8b17b15
Show file tree
Hide file tree
Showing 285 changed files with 476 additions and 431 deletions.
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Replace deprectated importsNotUsedAsValues option with verbatimModuleSyntax",
"packageName": "@ni/nimble-angular",
"email": "[email protected]",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Replace deprectated importsNotUsedAsValues option with verbatimModuleSyntax",
"packageName": "@ni/nimble-components",
"email": "[email protected]",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{
"type": "patch",
"comment": "Replace deprectated importsNotUsedAsValues option with verbatimModuleSyntax",
"packageName": "@ni/spright-components",
"email": "[email protected]",
"dependentChangeType": "patch"
}
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
/* eslint-disable no-alert */
import { AfterViewInit, Component, Inject, ViewChild } from '@angular/core';
import { type AfterViewInit, Component, Inject, ViewChild } from '@angular/core';
import { ActivatedRoute } from '@angular/router';
import { DrawerLocation, MenuItem, NimbleDialogDirective, NimbleDrawerDirective, OptionNotFound, OPTION_NOT_FOUND, UserDismissed, SelectFilterInputEventDetail, NimbleSelectDirective } from '@ni/nimble-angular';
import { NimbleTableDirective, TableRecordDelayedHierarchyState, TableRecord, TableRowExpansionToggleEventDetail, TableSetRecordHierarchyOptions } from '@ni/nimble-angular/table';
import { DrawerLocation, type MenuItem, NimbleDialogDirective, NimbleDrawerDirective, type OptionNotFound, OPTION_NOT_FOUND, UserDismissed, type SelectFilterInputEventDetail, NimbleSelectDirective } from '@ni/nimble-angular';
import { NimbleTableDirective, TableRecordDelayedHierarchyState, type TableRecord, type TableRowExpansionToggleEventDetail, type TableSetRecordHierarchyOptions } from '@ni/nimble-angular/table';
import { NimbleRichTextEditorDirective } from '@ni/nimble-angular/rich-text/editor';
import { BehaviorSubject, Observable } from 'rxjs';
import type { MenuButtonColumnToggleEventDetail } from '@ni/nimble-angular/table-column/menu-button';
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Component, ElementRef, ViewChild } from '@angular/core';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import { LabelProviderCore, NimbleLabelProviderCoreDirective } from '../nimble-label-provider-core.directive';
import { type LabelProviderCore, NimbleLabelProviderCoreDirective } from '../nimble-label-provider-core.directive';
import { NimbleLabelProviderCoreModule } from '../nimble-label-provider-core.module';

describe('Nimble Label Provider Core', () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Component, ElementRef, ViewChild } from '@angular/core';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import { LabelProviderRichText, NimbleLabelProviderRichTextDirective } from '../nimble-label-provider-rich-text.directive';
import { type LabelProviderRichText, NimbleLabelProviderRichTextDirective } from '../nimble-label-provider-rich-text.directive';
import { NimbleLabelProviderRichTextModule } from '../nimble-label-provider-rich-text.module';

describe('Nimble Label Provider Rich text', () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Component, ElementRef, ViewChild } from '@angular/core';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import { LabelProviderTable, NimbleLabelProviderTableDirective } from '../nimble-label-provider-table.directive';
import { type LabelProviderTable, NimbleLabelProviderTableDirective } from '../nimble-label-provider-table.directive';
import { NimbleLabelProviderTableModule } from '../nimble-label-provider-table.module';

describe('Nimble Label Provider Table', () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import { NimbleMappingDirective } from '@ni/nimble-angular/mapping/base';
import { type MappingIcon, mappingIconTag } from '@ni/nimble-components/dist/esm/mapping/icon';
import type { MappingKey } from '@ni/nimble-components/dist/esm/mapping/base/types';
import type { IconSeverity } from '@ni/nimble-components/dist/esm/icon-base/types';
import { BooleanValueOrAttribute, toBooleanProperty } from '@ni/nimble-angular/internal-utilities';
import { type BooleanValueOrAttribute, toBooleanProperty } from '@ni/nimble-angular/internal-utilities';

export type { MappingIcon };
export { mappingIconTag };
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { Directive, ElementRef, Input, Renderer2 } from '@angular/core';
import { NimbleMappingDirective } from '@ni/nimble-angular/mapping/base';
import { type MappingSpinner, mappingSpinnerTag } from '@ni/nimble-components/dist/esm/mapping/spinner';
import type { MappingKey } from '@ni/nimble-components/dist/esm/mapping/base/types';
import { BooleanValueOrAttribute, toBooleanProperty } from '@ni/nimble-angular/internal-utilities';
import { type BooleanValueOrAttribute, toBooleanProperty } from '@ni/nimble-angular/internal-utilities';

export type { MappingSpinner };
export { mappingSpinnerTag };
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { Component, ElementRef, ViewChild } from '@angular/core';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import { NimbleRichTextMentionUsersModule } from '../../../rich-text-mention/users/nimble-rich-text-mention-users.module';
import { NimbleRichTextEditorModule } from '../../../rich-text/editor/nimble-rich-text-editor.module';
import { MappingUser, NimbleMappingUserDirective } from '../nimble-mapping-user.directive';
import { type MappingUser, NimbleMappingUserDirective } from '../nimble-mapping-user.directive';
import { NimbleMappingUserModule } from '../nimble-mapping-user.module';

describe('NimbleMappingUser', () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Inject, LOCALE_ID, Pipe, PipeTransform } from '@angular/core';
import { Inject, LOCALE_ID, Pipe, type PipeTransform } from '@angular/core';
import { DurationFormatter } from '@ni/nimble-components/dist/esm/table-column/duration-text/models/duration-formatter';

/**
Expand Down
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
import { Inject, LOCALE_ID, Pipe, PipeTransform } from '@angular/core';
import { NumberTextUnitFormat, NumberTextUnitFormatOptions } from '@ni/nimble-components/dist/esm/table-column/number-text/models/number-text-unit-format';
import { Inject, LOCALE_ID, Pipe, type PipeTransform } from '@angular/core';
import { NumberTextUnitFormat, type NumberTextUnitFormatOptions } from '@ni/nimble-components/dist/esm/table-column/number-text/models/number-text-unit-format';

/**
* A pipe that transforms a number into a string with optional unit
Expand Down
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
import { Component, ElementRef, Pipe, PipeTransform, ViewChild } from '@angular/core';
import { Component, ElementRef, Pipe, type PipeTransform, ViewChild } from '@angular/core';
import { TestBed, type ComponentFixture } from '@angular/core/testing';

describe('Custom pipe instantiation', () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import type { RichTextMentionValidity } from '@ni/nimble-components/dist/esm/ric
import type { MentionUpdateEventDetail } from '@ni/nimble-components/dist/esm/rich-text-mention/base/types';
import type { RichTextMention } from '@ni/nimble-components/dist/esm/rich-text-mention/base';

export { RichTextMentionValidity };
export type { RichTextMentionValidity };
export type { MentionUpdateEventDetail };

/**
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { Component, ElementRef, ViewChild } from '@angular/core';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import { NimbleRichTextMentionUsersModule } from '../nimble-rich-text-mention-users.module';
import { NimbleRichTextEditorModule } from '../../../rich-text/editor/nimble-rich-text-editor.module';
import { NimbleRichTextMentionUsersDirective, RichTextMentionUsers } from '../nimble-rich-text-mention-users.directive';
import { NimbleRichTextMentionUsersDirective, type RichTextMentionUsers } from '../nimble-rich-text-mention-users.directive';

describe('NimbleRichTextMentionUsers', () => {
describe('module', () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,10 +1,10 @@
import { Directive, ElementRef, EventEmitter, HostListener, Input, Output, Renderer2 } from '@angular/core';
import type { RichTextEditor } from '@ni/nimble-components/dist/esm/rich-text/editor';
import { BooleanValueOrAttribute, toBooleanProperty } from '@ni/nimble-angular/internal-utilities';
import { type BooleanValueOrAttribute, toBooleanProperty } from '@ni/nimble-angular/internal-utilities';
import type { RichTextValidity } from '@ni/nimble-components/dist/esm/rich-text/base/types';

export type { RichTextEditor };
export { RichTextValidity };
export type { RichTextValidity };

/**
* Directive to provide Angular integration for the rich text editor element.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { ComponentFixture, TestBed } from '@angular/core/testing';
import { Component, ElementRef, ViewChild } from '@angular/core';
import type { BooleanValueOrAttribute } from '@ni/nimble-angular/internal-utilities';
import { NimbleRichTextEditorModule } from '../nimble-rich-text-editor.module';
import { NimbleRichTextEditorDirective, RichTextEditor } from '../nimble-rich-text-editor.directive';
import { NimbleRichTextEditorDirective, type RichTextEditor } from '../nimble-rich-text-editor.directive';

describe('Nimble Rich Text Editor', () => {
describe('module', () => {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import type { RichTextViewer } from '@ni/nimble-components/dist/esm/rich-text/vi
import type { RichTextValidity } from '@ni/nimble-components/dist/esm/rich-text/base/types';

export type { RichTextViewer };
export { RichTextValidity };
export type { RichTextValidity };

/**
* Directive to provide Angular integration for the rich text viewer element.
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { ComponentFixture, TestBed } from '@angular/core/testing';
import { Component, ElementRef, ViewChild } from '@angular/core';
import { NimbleRichTextViewerModule } from '../nimble-rich-text-viewer.module';
import { NimbleRichTextViewerDirective, RichTextViewer } from '../nimble-rich-text-viewer.directive';
import { NimbleRichTextViewerDirective, type RichTextViewer } from '../nimble-rich-text-viewer.directive';

describe('Nimble Rich Text Viewer', () => {
describe('module', () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Directive, ElementRef, Input, Renderer2 } from '@angular/core';
import { type AnchorButton, anchorButtonTag } from '@ni/nimble-components/dist/esm/anchor-button';
import type { ButtonAppearance, ButtonAppearanceVariant } from '@ni/nimble-components/dist/esm/anchor-button/types';
import { BooleanValueOrAttribute, toBooleanProperty } from '@ni/nimble-angular/internal-utilities';
import { type BooleanValueOrAttribute, toBooleanProperty } from '@ni/nimble-angular/internal-utilities';
import { NimbleAnchorBaseDirective } from '../anchor-base/nimble-anchor-base.directive';

export type { AnchorButton };
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { Component, ElementRef, ViewChild } from '@angular/core';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import type { BooleanValueOrAttribute } from '@ni/nimble-angular/internal-utilities';
import { ButtonAppearance, ButtonAppearanceVariant } from '../../../public-api';
import { AnchorButton, NimbleAnchorButtonDirective } from '../nimble-anchor-button.directive';
import { type AnchorButton, NimbleAnchorButtonDirective } from '../nimble-anchor-button.directive';
import { NimbleAnchorButtonModule } from '../nimble-anchor-button.module';

describe('Nimble anchor button', () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Directive, ElementRef, Input, Renderer2 } from '@angular/core';
import { type AnchorMenuItem, anchorMenuItemTag } from '@ni/nimble-components/dist/esm/anchor-menu-item';
import { BooleanValueOrAttribute, toBooleanProperty } from '@ni/nimble-angular/internal-utilities';
import { type BooleanValueOrAttribute, toBooleanProperty } from '@ni/nimble-angular/internal-utilities';
import { NimbleAnchorBaseDirective } from '../anchor-base/nimble-anchor-base.directive';

export type { AnchorMenuItem };
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Directive, ElementRef, Input, Renderer2 } from '@angular/core';
import { type AnchorTab, anchorTabTag } from '@ni/nimble-components/dist/esm/anchor-tab';
import { BooleanValueOrAttribute, toBooleanProperty } from '@ni/nimble-angular/internal-utilities';
import { type BooleanValueOrAttribute, toBooleanProperty } from '@ni/nimble-angular/internal-utilities';
import { NimbleAnchorBaseDirective } from '../anchor-base/nimble-anchor-base.directive';

export type { AnchorTab };
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Component, ElementRef, ViewChild } from '@angular/core';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import { AnchorTab, NimbleAnchorTabDirective } from '../nimble-anchor-tab.directive';
import { type AnchorTab, NimbleAnchorTabDirective } from '../nimble-anchor-tab.directive';
import { NimbleAnchorTabModule } from '../nimble-anchor-tab.module';

describe('Nimble anchor tab', () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Directive, ElementRef, Input, Renderer2 } from '@angular/core';
import { type AnchorTreeItem, anchorTreeItemTag } from '@ni/nimble-components/dist/esm/anchor-tree-item';
import { BooleanValueOrAttribute, toBooleanProperty } from '@ni/nimble-angular/internal-utilities';
import { type BooleanValueOrAttribute, toBooleanProperty } from '@ni/nimble-angular/internal-utilities';
import { NimbleAnchorBaseDirective } from '../anchor-base/nimble-anchor-base.directive';

export type { AnchorTreeItem };
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Component, ElementRef, ViewChild } from '@angular/core';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import type { BooleanValueOrAttribute } from '@ni/nimble-angular/internal-utilities';
import { AnchorTreeItem, NimbleAnchorTreeItemDirective } from '../nimble-anchor-tree-item.directive';
import { type AnchorTreeItem, NimbleAnchorTreeItemDirective } from '../nimble-anchor-tree-item.directive';
import { NimbleAnchorTreeItemModule } from '../nimble-anchor-tree-item.module';

describe('Nimble anchor tree item', () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Directive, ElementRef, Input, Renderer2 } from '@angular/core';
import { type Anchor, anchorTag } from '@ni/nimble-components/dist/esm/anchor';
import { AnchorAppearance } from '@ni/nimble-components/dist/esm/anchor/types';
import { BooleanValueOrAttribute, toBooleanProperty } from '@ni/nimble-angular/internal-utilities';
import { type BooleanValueOrAttribute, toBooleanProperty } from '@ni/nimble-angular/internal-utilities';
import { NimbleAnchorBaseDirective } from '../anchor-base/nimble-anchor-base.directive';

export type { Anchor };
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Component, ElementRef, ViewChild } from '@angular/core';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import { Anchor, AnchorAppearance, NimbleAnchorDirective } from '../nimble-anchor.directive';
import { type Anchor, AnchorAppearance, NimbleAnchorDirective } from '../nimble-anchor.directive';
import { NimbleAnchorModule } from '../nimble-anchor.module';

describe('Nimble anchor', () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Directive, ElementRef, EventEmitter, HostListener, Input, Output, Renderer2 } from '@angular/core';
import { type Banner, bannerTag } from '@ni/nimble-components/dist/esm/banner';
import { BannerSeverity, BannerToggleEventDetail } from '@ni/nimble-components/dist/esm/banner/types';
import { BooleanValueOrAttribute, toBooleanProperty } from '@ni/nimble-angular/internal-utilities';
import { BannerSeverity, type BannerToggleEventDetail } from '@ni/nimble-components/dist/esm/banner/types';
import { type BooleanValueOrAttribute, toBooleanProperty } from '@ni/nimble-angular/internal-utilities';

export type { Banner };
export { bannerTag };
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Component, ElementRef, ViewChild } from '@angular/core';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import { Banner, BannerSeverity, NimbleBannerDirective } from '../nimble-banner.directive';
import { type Banner, BannerSeverity, NimbleBannerDirective } from '../nimble-banner.directive';
import { NimbleBannerModule } from '../nimble-banner.module';

describe('Nimble banner', () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Component, ElementRef, ViewChild } from '@angular/core';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import { BreadcrumbItem, NimbleBreadcrumbItemDirective } from '../nimble-breadcrumb-item.directive';
import { type BreadcrumbItem, NimbleBreadcrumbItemDirective } from '../nimble-breadcrumb-item.directive';
import { NimbleBreadcrumbItemModule } from '../nimble-breadcrumb-item.module';

describe('Nimble breadcrumb item', () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Component, ElementRef, ViewChild } from '@angular/core';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import { Breadcrumb, BreadcrumbAppearance, NimbleBreadcrumbDirective } from '../nimble-breadcrumb.directive';
import { type Breadcrumb, BreadcrumbAppearance, NimbleBreadcrumbDirective } from '../nimble-breadcrumb.directive';
import { NimbleBreadcrumbModule } from '../nimble-breadcrumb.module';

describe('Nimble breadcrumb', () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,11 +1,11 @@
import { Directive, ElementRef, Input, Renderer2 } from '@angular/core';
import { type Button, buttonTag } from '@ni/nimble-components/dist/esm/button';
import type { ButtonType, ButtonAppearance, ButtonAppearanceVariant } from '@ni/nimble-components/dist/esm/button/types';
import { BooleanValueOrAttribute, toBooleanProperty } from '@ni/nimble-angular/internal-utilities';
import { type BooleanValueOrAttribute, toBooleanProperty } from '@ni/nimble-angular/internal-utilities';

export type { Button };
export { buttonTag };
export { ButtonType };
export type { ButtonType };

/**
* Directive to provide Angular integration for the button.
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ import { Component, ElementRef, ViewChild } from '@angular/core';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import type { BooleanValueOrAttribute } from '@ni/nimble-angular/internal-utilities';
import { ButtonAppearance, ButtonAppearanceVariant } from '../../../public-api';
import { Button, NimbleButtonDirective } from '../nimble-button.directive';
import { type Button, NimbleButtonDirective } from '../nimble-button.directive';
import { NimbleButtonModule } from '../nimble-button.module';

describe('Nimble button', () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Directive, ElementRef, Input, Renderer2 } from '@angular/core';
import { type CardButton, cardButtonTag } from '@ni/nimble-components/dist/esm/card-button';
import { BooleanValueOrAttribute, toBooleanProperty } from '@ni/nimble-angular/internal-utilities';
import { type BooleanValueOrAttribute, toBooleanProperty } from '@ni/nimble-angular/internal-utilities';

export type { CardButton };
export { cardButtonTag };
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Component, ElementRef, ViewChild } from '@angular/core';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import type { BooleanValueOrAttribute } from '@ni/nimble-angular/internal-utilities';
import { NimbleCardButtonDirective, CardButton } from '../nimble-card-button.directive';
import { NimbleCardButtonDirective, type CardButton } from '../nimble-card-button.directive';
import { NimbleCardButtonModule } from '../nimble-card-button.module';

describe('Nimble card button', () => {
Expand Down
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
import { Directive, ElementRef, Input, Renderer2 } from '@angular/core';
import { type Checkbox, checkboxTag } from '@ni/nimble-components/dist/esm/checkbox';
import { BooleanValueOrAttribute, toBooleanProperty } from '@ni/nimble-angular/internal-utilities';
import { type BooleanValueOrAttribute, toBooleanProperty } from '@ni/nimble-angular/internal-utilities';

export type { Checkbox };
export { checkboxTag };
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import { Component, ElementRef, ViewChild } from '@angular/core';
import { ComponentFixture, TestBed } from '@angular/core/testing';
import type { BooleanValueOrAttribute } from '@ni/nimble-angular/internal-utilities';
import { Checkbox, NimbleCheckboxDirective } from '../nimble-checkbox.directive';
import { type Checkbox, NimbleCheckboxDirective } from '../nimble-checkbox.directive';
import { NimbleCheckboxModule } from '../nimble-checkbox.module';

describe('Nimble checkbox', () => {
Expand Down
Loading

0 comments on commit 8b17b15

Please sign in to comment.