Add missing base color tokens for calendar theme aware tokens #2305
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jattasNI
reviewed
Jul 24, 2024
change/@ni-nimble-components-92f16ac4-28b7-4ff8-a111-f9a46fbc86aa.json
Outdated
Show resolved
Hide resolved
aagash-ni
changed the title
jattasNI
reviewed
Jul 26, 2024
change/@ni-nimble-tokens-b264b0ee-0471-4955-99c5-10e8b68dff74.json
Outdated
Show resolved
Hide resolved
packages/nimble-tokens/source/styledictionary/properties/colors.json
Outdated
Show resolved
Hide resolved
jattasNI
reviewed
Jul 29, 2024
packages/nimble-tokens/source/styledictionary/properties/colors.json
Outdated
Show resolved
Hide resolved
change/@ni-nimble-tokens-b264b0ee-0471-4955-99c5-10e8b68dff74.json
Outdated
Show resolved
Hide resolved
jattasNI
approved these changes
Jul 30, 2024
|
Changes are now pretty trivial, don't think this needs review from @rajsite or @fredvisser but feel free to comment afterwards or on the follow up PR. I marked this for auto-merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Added the missing base color tokens required to create calendar theme-aware tokens according to the mockup.
Figma Mockup: https://dev.azure.com/ni/DevCentral/_wiki/wikis/AppCentral.wiki/118969/Schedule-Test-Plans
Azdo Discussion for reference: https://dev.azure.com/ni/DevCentral/_git/Skyline/pullRequest/750620#1720658507
👩💻 Implementation
Note: Calendar theme-aware tokens will be added in the follow-up PR
🧪 Testing
NA
✅ Checklist