Listbox padding #2341
Closed
Listbox padding #2341
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rajsite
reviewed
Aug 12, 2024
rajsite
reviewed
Aug 13, 2024
| @@ -220,6 +220,7 @@ export const styles = css` | |||
| box-shadow: ${elevation2BoxShadow}; | |||
| border: ${borderWidth} solid ${popupBorderColor}; | |||
| background-color: ${applicationBackgroundColor}; | |||
| padding: var(--ni-private-listbox-padding); | |||
There was a problem hiding this comment.
on windows this change is resulting in the padding being around the scrollable region which seems off.
main:
pr:
There was a problem hiding this comment.
There are also some suspicious Chromatic diffs. For example, the Search field seems squished and the No items found item seems taller
There was a problem hiding this comment.
@fredvisser fyi the latest commit does still seem to impact the scrollbar, notice the top and bottom of the list box:
There was a problem hiding this comment.
Closing the loop - the initial behavior (padding around the scrollbar) is the intended design.
However, @atmgrifter00 says he has this fix in a branch, so I'll abandon this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
🤨 Rationale
Brandon noted that the visual design for select, combobox, and mention, specifies a 4px 'mat' around the options, even when the content is scrolling.
👩💻 Implementation
Screen.Recording.2024-08-09.at.3.31.34.PM.mp4
padding: var(--ni-private-listbox-padding);from the scrollable content, to the fixed listbox containercomboboxtemplate more consistent with theselecttemplate, so the shared styling at the same effect (i.e. moved thescrollable-regionclass into it's own div)🧪 Testing
✅ Checklist