Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Required indicator on text-field and number-field #2507

Merged
merged 2 commits into from
Jan 8, 2025

Conversation

mollykreis
Copy link
Contributor

@mollykreis mollykreis commented Jan 7, 2025

Pull Request

🀨 Rationale

Add required-visible attributes to the text-field and number-field as part of #2100.

πŸ‘©β€πŸ’» Implementation

Used the newly established pattern for required-visible to add required-visible to the text-field and number-field.

πŸ§ͺ Testing

  • New unit tests for aria-required on both components
  • Manually tested both components in storybook
  • Storybook updates
  • Matrix test updates
  • Updated required-visible story

βœ… Checklist

  • I have updated the project documentation to reflect my changes or determined no changes are needed.

@mollykreis
Copy link
Contributor Author

Creating this PR to replace #2506 because the chromatic diff of the associated branch got in a bad state.

@mollykreis mollykreis marked this pull request as ready for review January 7, 2025 22:36
@rajsite rajsite merged commit a0662f1 into main Jan 8, 2025
14 checks passed
@rajsite rajsite deleted the more-required-visible-2 branch January 8, 2025 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants