Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update metadata before 1.4.8 release #2055

Merged
merged 9 commits into from
Apr 26, 2024

Conversation

ni-jfitzger
Copy link
Collaborator

@ni-jfitzger ni-jfitzger commented Apr 25, 2024

  • This contribution adheres to CONTRIBUTING.md.
  • I've updated CHANGELOG.md if applicable.
  • I've added tests applicable for this pull request

What does this Pull Request accomplish?

Update metadata to latest 24.3 export for most APIs.
Not Updated:

  • nifgen is being updated in a separate PR
  • niswitch had an unintended breaking change which I have an internal PR to fix, but I won't hold up the release for it

Resulting Changes:

  • nidcpower has some documentation changes (mostly/all? just deletion of the word 'output')
  • nidmm: cal_type_raw was changed to cal_type in _grpc_stub_interpreter.py
  • Several apis had the order of things changed in their .proto files and the resulting generated files
    • If there were other changes, it's virtually impossible to tell, but our tests are passing
  • The order of some imports changed in nifake

No new functions, properties, enums, classes, structs were added to any of the APIs

List issues fixed by this Pull Request below, if any.

None

What testing has been done?

PR Checks

- just attribute and function documentation changes
- no metadata changes
- .proto file seems to have changed the order of some things
- 'grpc_enum': 'CalibrationType' deleted from a couple of functions
- proto file re-ordered
- Some custom types reordered
- .proto file reordered
- .proto file reordered
@ni-jfitzger ni-jfitzger marked this pull request as ready for review April 26, 2024 01:07
@marcoskirsch
Copy link
Member

Don't we usually add something like "API parity with NI-Digital Pattern Driver 2x.0.0." to the CHANGELOG in these PRs?

Copy link
Member

@marcoskirsch marcoskirsch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm if this should include CHANGELOG changes.
Should only be mentioned where the API changes are actually visible.

@ni-jfitzger
Copy link
Collaborator Author

Don't we usually add something like "API parity with NI-Digital Pattern Driver 2x.0.0." to the CHANGELOG in these PRs?

There's only evidence of us doing that when we add new functions, properties, enums, etc for API parity. This PR includes no user-visible API changes. I'm not sure what's going on with that NI-DMM grpc change, but we test both of those functions and the tests passed.

@ni-jfitzger
Copy link
Collaborator Author

ni-jfitzger commented Apr 26, 2024

Please confirm if this should include CHANGELOG changes. Should only be mentioned where the API changes are actually visible.

There is nothing that warrants touching the changelog. I carefully reviewed the metadata changes, multiple times, and I reviewed the output as well. All changes that I found are noted in the description.

Copy link
Collaborator

@tobiasgordon tobiasgordon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This all looks fine to me.

@ni-jfitzger ni-jfitzger merged commit 67cc13a into ni:master Apr 26, 2024
35 checks passed
@ni-jfitzger ni-jfitzger deleted the update-metadata branch April 26, 2024 17:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants