-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update metadata before 1.4.8 release #2055
Conversation
- just attribute and function documentation changes
- no metadata changes - .proto file seems to have changed the order of some things
- 'grpc_enum': 'CalibrationType' deleted from a couple of functions - proto file re-ordered
- Some custom types reordered - .proto file reordered
- .proto file reordered
- no change
- No changes
Don't we usually add something like "API parity with NI-Digital Pattern Driver 2x.0.0." to the CHANGELOG in these PRs? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please confirm if this should include CHANGELOG changes.
Should only be mentioned where the API changes are actually visible.
There's only evidence of us doing that when we add new functions, properties, enums, etc for API parity. This PR includes no user-visible API changes. I'm not sure what's going on with that NI-DMM grpc change, but we test both of those functions and the tests passed. |
There is nothing that warrants touching the changelog. I carefully reviewed the metadata changes, multiple times, and I reviewed the output as well. All changes that I found are noted in the description. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks fine to me.
I've updated CHANGELOG.md if applicable.I've added tests applicable for this pull requestWhat does this Pull Request accomplish?
Update metadata to latest 24.3 export for most APIs.
Not Updated:
Resulting Changes:
cal_type_raw
was changed tocal_type
in _grpc_stub_interpreter.pyNo new functions, properties, enums, classes, structs were added to any of the APIs
List issues fixed by this Pull Request below, if any.
None
What testing has been done?
PR Checks