feat: Add client for SystemLink products API #69
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamarnesen
commented
Aug 9, 2024
adamarnesen
changed the title
nisystemlink/clients/testmonitor/models/_delete_products_partial_success.py
Outdated
Show resolved
Hide resolved
nisystemlink/clients/testmonitor/models/_query_products_request.py
Outdated
Show resolved
Hide resolved
mure
reviewed
Oct 25, 2024
There was a problem hiding this comment.
During the planning for Grafana plugins for Test Monitor, there was a discussion of if we should have one "Test Monitor" plugin or separate plugins for products, test results, etc. The consensus was that Products should be its own plugin, because that's the way our customers understand SystemLink. The fact that it's one microservice is an implementation detail. Should we apply the same logic here and have a ProductClient?
nisystemlink/clients/testmonitor/models/_create_products_request.py
Outdated
Show resolved
Hide resolved
nisystemlink/clients/testmonitor/models/_query_products_request.py
Outdated
Show resolved
Hide resolved
adamarnesen
changed the title
|
@mure I like the idea of having a |
santhoshramaraj
approved these changes
Nov 5, 2024
… have room for the generator pattern
mure
approved these changes
Nov 8, 2024
santhoshramaraj
approved these changes
Nov 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
This PR adds client methods for all of the
nitestmonitorproduct endpoints as well as testing for these endpoints.Why should this Pull Request be merged?
This is an enhancement to the existing test monitor client and will enable users to more easily interact with SystemLink products.
What testing has been done?
Auto testing is included against NI's test tier.