feat: Add minimal client implementation for auth services #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Giriharan219
requested review from
mure,
spanglerco and
cameronwaterman
as code owners
Giriharan219
changed the title
santhoshramaraj
requested changes
Nov 4, 2024
| from . import models | ||
|
|
||
|
|
||
| class AuthClient(BaseClient): |
There was a problem hiding this comment.
Naming this AccessControlClient makes it intuitive and clubs the related feature across multiple services under the same client.
@mure, @spanglerco, @cameronwaterman - please share your thoughts
Giriharan219
force-pushed
the
users/gravichandran/add-auth-client
branch
from
627888a to
5d0f4bf
Compare
Giriharan219
force-pushed
the
users/gravichandran/add-auth-client
branch
from
5d0f4bf to
ad7e3f0
Compare
Giriharan219
force-pushed
the
users/gravichandran/add-auth-client
branch
from
5e854a2 to
b6b1c51
Compare
Giriharan219
force-pushed
the
users/gravichandran/add-auth-client
branch
from
b6b1c51 to
bfd9308
Compare
|
Most of this functionality seems pretty core to the fundamental operations. Would it make more sense to bake this into a base class shared across the various APIs instead of having an explicit API just for this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
This PR adds some client methods for auth endpoints and testing for these endpoints.
Why should this Pull Request be merged?
This Minimal client for auth APIs will enable users to more easily interact with that APIs.
What testing has been done?
Auto testing is included against NI's test tier.
API Link: Swagger-link