feat: Add client for Notebook & Notebook Execution APIs. #87
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ganesh Nithin <[email protected]>
Signed-off-by: Ganesh Nithin <[email protected]>
Signed-off-by: Ganesh Nithin <[email protected]>
Signed-off-by: Ganesh Nithin <[email protected]>
Signed-off-by: Ganesh Nithin <[email protected]>
Signed-off-by: Ganesh Nithin <[email protected]>
Signed-off-by: Ganesh Nithin <[email protected]>
Signed-off-by: Ganesh Nithin <[email protected]>
Signed-off-by: Ganesh Nithin <[email protected]>
ganesh-nithin
changed the title
Signed-off-by: Ganesh Nithin <[email protected]>
Signed-off-by: Ganesh Nithin <[email protected]>
Signed-off-by: Ganesh Nithin <[email protected]>
Signed-off-by: Ganesh Nithin <[email protected]>
ganesh-nithin
requested review from
mure,
spanglerco and
cameronwaterman
as code owners
|
In the interest of SLS compatibility, would it make sense to implement this using the webapp service instead of the Notebook service? If you did it in a base class that this inherited from, that could also set the stage for WebVI/SPAs interactions. |
I think that this is just trying to add a good wrapper on the HTTP APIs for notebook execution. I think probably the compatibility layer with SLS would be on top of these APIs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this Pull Request accomplish?
This PR adds client methods for
Notebook ServiceandNotebook Execution Serviceendpoints with integration tests for these endpointsWhy should this Pull Request be merged?
This notebook client will improve user interactivity with those
Notebook ServiceandNotebook Execution Serviceendpoints.What testing has been done?
Automated integration tests are included.
API Link: Swagger-link