Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Dynamic Form Field Configuration Example #15

Open
wants to merge 30 commits into
base: main
Choose a base branch
from

Conversation

ChrisDecombe
Copy link

After discussion we Josh we decided to use the existing Github repository to prepare and publish an example of a Dynamic Form Fields configuration.

Dynamic Form Fields Configuration Example/README.md Outdated Show resolved Hide resolved
Dynamic Form Fields Configuration Example/README.md Outdated Show resolved Hide resolved
Dynamic Form Fields Configuration Example/README.md Outdated Show resolved Hide resolved
Dynamic Form Fields Configuration Example/README.md Outdated Show resolved Hide resolved
Dynamic Form Fields Configuration Example/README.md Outdated Show resolved Hide resolved
Dynamic Form Fields Configuration Example/README.md Outdated Show resolved Hide resolved
Dynamic Form Fields Configuration Example/README.md Outdated Show resolved Hide resolved
Dynamic Form Fields Configuration Example/README.md Outdated Show resolved Hide resolved
@ChrisDecombe
Copy link
Author

@adamarnesen I need a reviewer for this changes in SLE example repo.
I have added a new section with an example of the DFF configuration.

Could you check my pull request?
Josh has already checked it.

This DFF Configuration example would look this this:

image

Copy link
Collaborator

@prestwick prestwick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may be worthwhile is have several distinct examples rather than this one big example.

@ChrisDecombe
Copy link
Author

It may be worthwhile is have several distinct examples rather than this one big example.

I have just removed the second group to keep it simple.
I have kept one example of each field type in the single group...
Would it be ok for you like this?

Josh wanted to have several groups that's why I have added a second group BUT I agree we should have an simple example.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants