This repository has been archived by the owner on Aug 27, 2020. It is now read-only.
Remove onDidChange callbacks
#60
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They were not returning a valid `Disposable` object and, since they were not used internally, we can delete them so that atom/tabs#183 is not a problem anymore.
|
Bumping this one. Just experienced atom/tabs#183 |
|
Merge already :) |
|
bump |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They were not returning a valid
Disposableobject and, since they were not used internally, we can delete them so that atom/tabs#183 is not a problem anymore.For some reason I am not able to run this package by cloning it and running
apm link. Any ideas of what’s going on there?Nice job with this package, by the way! ✨