-
Notifications
You must be signed in to change notification settings - Fork 225
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(service): Add matrix service #410
Conversation
Normally I reformatted with gofumpt. My bad, didn't see that you used a different formatter P.S. Maybe you can put it in the how to contribute page? |
Codecov ReportBase: 63.55% // Head: 64.06% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #410 +/- ##
==========================================
+ Coverage 63.55% 64.06% +0.51%
==========================================
Files 30 32 +2
Lines 1029 1091 +62
==========================================
+ Hits 654 699 +45
- Misses 316 326 +10
- Partials 59 66 +7
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…ervice-matrix # Conflicts: # service/matrix/matrix_test.go
@nikoksr Leaving this comment here cause I think that's a good idea to consider. |
100% agree. We can go over the step-by-step guide and make it a little bit more granular probably. Thanks for the feedback @arnocornette. |
I think the linter will not complain now but it's hard as the lint action does not give the filenames it doesn't work on |
@arnocornette not sure if you're aware of it, but you can run We'll definitely clarify the step-by-step section in the contrib guide. |
Greatly appreciate your contribution, @arnocornette! And thanks again for the feedback. |
Awesome work, thank you! ❤️ |
Description
Adds a notifier service for Matrix
Motivation and Context
This addresses #283 partially. I decided to split up the Matrix and Signal PRs as tey are two features in one ticket.
Matrix is an open standard and communication protocl for real-time communication.
How Has This Been Tested?
I tested this in 2 steps:
Screenshots / Output (if appropriate):
This is output from several runs.
Types of changes
Checklist: