fix the ds list script so it works with the new gbasf2 version #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously we only raised an exception for returncodes of 3 and otherwise accepted the output. Any other returncodes should in theory not be possible but better be defensive and fail early with a proper error message instead of accepting garbage output and failing later with a confusing error message.
|
LGTM 👍. Just changelog missing, that could be combined with the changelog entry for #209 into a single bulletpoint |
meliache
added
bug
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
==========================================
+ Coverage 60.51% 60.80% +0.28%
==========================================
Files 23 23
Lines 1593 1597 +4
==========================================
+ Hits 964 971 +7
+ Misses 629 626 -3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
meliache
approved these changes
Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the new
gbasf2version,userCredschanged path andinitializeCS()is not automatic anymore. This PR fix the crash happening whenb2luigitries to download the jobs output.Same solution as in #209 .