-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP for validation of complex properties #170
Draft
ghost
wants to merge
841
commits into
develop
Choose a base branch
from
i144-form-control
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update labels for embargo and lease
skip parsing date if its format is invalid (usually it is year)
Internal release for NGDR
refactor of complex_person spec
update user manual url
add remember_token to users table
disable citation template temporarily
remove pry from complex_fields_behaviour.rb
Features/i183 helpers unit tests
Feature/i229 landing page
add Handle identifier to the authority file
Temporarily disable apis
add CAS_DESTINATION_URL
small fix for i239 app reload bug
make some methods supporting multi-value
Feature/i224 tabular data viewer
…nd-specimens Expanded temporary validation on complex instrument and specimen to stop form…
Use default thumbnail for .txt, .csv and .tsv
require faraday_middleware
Fix issue with "search for works" user profile
Bug fix for csv preview
add .mvn directory to store local jvm.config
ghost
force-pushed
the
i144-form-control
branch
2 times, most recently
from
March 4, 2020 12:48
2cf4932
to
5192989
Compare
roll out the required-if-any code to all inputs; add condition to skip operator (as thats prefilled) add conditional; extended required fields
ghost
force-pushed
the
i144-form-control
branch
from
April 15, 2020 12:45
9107c04
to
b4afa55
Compare
orangewolf
reviewed
Apr 29, 2020
@@ -22,5 +22,5 @@ | |||
// Required by Blacklight | |||
//= require blacklight/blacklight | |||
|
|||
//= require_tree . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can I ask why this change + the require almond below?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I seem to recall needing it, but I'll test without.
nabeta
force-pushed
the
i144-form-control
branch
from
October 10, 2024 07:13
e7ddd13
to
3296db7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(144)
This PR does the following:
ComplexValidation
The code meets the 'required if any' case, and is configured to support the following cases:
Where the role is 'operator' the condition is skipped as this is pre-populated in the instrument tab of dataset and we do no want this field to be required by default.
The code meets the 'required if conditional' , and is configured to support the following case:
CAVEAT: I would caution against the over-use of conditional requirements, it makes the form very busy - the javascript has to loop through the form multiple times and I am concerned about performance if it is doing this for mulitiple different conditions. I have added role as an example.
I have observed 'unresponsive' errors in the browser. The needs testing in a more production-like environment where the JS is precompiled.
TODO: