Add comments to commands for clarity #68
Conversation
| edition set 22 | ||
| edition set 23 |
There was a problem hiding this comment.
I can't tell if this is a pure comment update or if it has actual code changes that might break something and therefore needs an edition revision. Which is it?
There was a problem hiding this comment.
See my comment below.
There was a problem hiding this comment.
I would say if it's a pure (micro-)optimization that shouldn't be able to break anything, there's probably no need for a new edition.
But that's also why it's not great to make code and formatting (like comments) changes at the same time, because the tiny code update/fix/etc. that actually alters the binary gets hidden by the big line count changes that don't.
| bra L0069 | ||
| bne ExitShell exit shell if so | ||
| noparms@ lds ,s++ get Y off stack pushed earlier (end of parameter area) | ||
| ProcLine tst <suppressintro do we suppress showing the intro? |
There was a problem hiding this comment.
@Deek a subtle optimization... I now test the "supressintro" flag before setting X two lines down. The other code set X first and then did the test. It may not justify incrementing the edition byte. Let me know what you think.
| edition set 22 | ||
| edition set 23 |
There was a problem hiding this comment.
See my comment below.
No description provided.