Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixpkgs-fmt is now nixfmt #264

Merged
merged 1 commit into from
Jan 10, 2025
Merged

Conversation

nicdumz
Copy link
Contributor

@nicdumz nicdumz commented Jan 10, 2025

https://github.com/nix-community/nixpkgs-fmt has been archived in favor of https://github.com/NixOS/nixfmt, we can delete the mention of the former to simplify life to newcomers.

@nicdumz nicdumz marked this pull request as draft January 10, 2025 15:15
@nicdumz nicdumz marked this pull request as ready for review January 10, 2025 15:20
Copy link
Member

@cyntheticfox cyntheticfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I approve with the idea, but nixpkgs-fmt should just be moved to the /DEPRECATED.md list instead of deleted. Otherwise it looks good

https://github.com/nix-community/nixpkgs-fmt has been archived in favor of https://github.com/NixOS/nixfmt, we can delete the mention of the former to simplify life to newcomers.

Note the organization repo transfer to NixOS too.
Copy link
Member

@cyntheticfox cyntheticfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now!

@cyntheticfox cyntheticfox merged commit fa26c13 into nix-community:main Jan 10, 2025
2 checks passed
@nicdumz nicdumz deleted the patch-1 branch January 10, 2025 21:22
@@ -20,6 +20,10 @@ Here lie the following former awesome-list members as they have been archived, d

* [NixOS Weekly](https://weekly.nixos.org/) - *The* newsletter to stay informed about community updates. (Last update was made in 2021)

## Command-Line Tools

* [nixpkgs-fmt](https://github.com/nix-community/nixpkgs-fmt) formatter is now [nixfmt](https://github.com/NixOS/nixfmt).
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That wording is kinda wrong. It has been replaced but it is not same thing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry. Want to follow-up with a fix? For me the most important part was to remove the duplication/confusion from the landing page; actual wording on DEPRECATED.md matters not very much to me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants