Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
cargo
crate dependency is perennially awkward. I think it would be better to shell out to Cargo commands and use thecargo_metadata
crate so we don’t have to keep doing this. Needs NixOS/nixpkgs#373096 to build (and was tested with--override-input nixpkgs github:NixOS/nixpkgs/pull/373096/head
), but I’d like to get a release cut with this so that we don’t have to vendor a gigantic patch to theCargo.lock
in Nixpkgs.