login: Do not dereference proot binds /bin and /etc
#353
Conversation
|
Nice, this might've been the stuff I've been fighting about a year ago, judging by the age of the bin-less branch |
|
(also, consider adding yourself to AUTHORS) |
|
@t184256 Anything left for this PR to be merged? |
|
No, actually; with no email notifications from that update of yours, I just forgot about it. Rebased, waiting for the CI... |
|
Hm, now tests that check for the absence of some commands fail. If that's because they now find the system ones, why would /system/bin be in |
|
I've just checked my old nix-on-droid setup (not upgraded to current HEAD yet), I changed the shell to |
|
Sorry, the mistake is probably on CI side, as test_channels_uiautomator passes (when tests run properly by typing the command into the app), it's test_channels_shell fails (when tests are run in a hackish way to get better output). I'll see what happens to |
`/bin` and `/etc` are symlinks to `/system/bin` and `/system/etc`, by default proot will dereference and override them with new contents. After this change, `/system/bin` and `/system/etc` are kept untouched, so commands like `/system/bin/ping` can be run directly.
|
Yeah, a CI problem indeed. Added a commit that sets empty PATH, because just unsetting it isn't enough (something's too smart and sets defaults back), and also unsetting everything messes up more stuff. Let's see whether that solves the issue... |
|
Done, thank you for that great fix, and sorry for forgetting about this one! |
/binand/etcare symlinks to/system/binand/system/etc, by default proot will dereference and override them with new contents.After this change,
/system/binand/system/etcare kept untouched, so commands like/system/bin/pingcan be run directly.