-
-
Notifications
You must be signed in to change notification settings - Fork 298
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
experimental configuration-based nixvim template #2854
Conversation
46cca53
to
b92e08c
Compare
50a7d65
to
94fd1ae
Compare
This looks very promising ! |
This comment has been minimized.
This comment has been minimized.
This comment was marked as resolved.
This comment was marked as resolved.
d42ee40
to
88f5e37
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a MUCH cleaner way to handle standalone modules!
It should also be much simpler to have a flake which uses standalone modules for rapid iteration & and exposes neovim through an home manager module with this kind of architecture
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm really liking this. Right now my standalone setup feels hacky for creating the actual package output and this keeps it all modules and configuration without worrying about the flake output aspect, as much.
88f5e37
to
89d8a12
Compare
89d8a12
to
5b1e9ed
Compare
5b1e9ed
to
ec0d3c7
Compare
ec0d3c7
to
ff97c64
Compare
This template uses the lower-level `evalNixvim` function to work directly with nixvim configurations, instead of the prior idiom of using `makeNixvim` to produce nixvim packages. Additionally, the template is build on flake.parts, and demonstrates using our recently added flakeModules.
ff97c64
to
342161b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not too concerned about the name personally.
We should figure out a way to document the templates, maybe by adding their README to sections in the main book
@mergify queue |
✅ The pull request has been merged automaticallyThe pull request has been merged automatically at 342161b |
This pull request, with head sha This pull request will be automatically closed by GitHub.As soon as GitHub detects that the sha It is possible for this pull request to remain open if this detection does not happen, this usually happens when a force-push is done on this branch |
Adds an experimental flake template that configures Nixvim directly using
evalNixvim
rather than the current standalone functions.Related issues
nixvimConfig
) #2210auto
flake-parts module #2867evalNixvim
as top-level alias #2868Real world usage
Todo
checks
are inherited into the main flake'schecks
nixvim-print-init
inbuild.package
modules/output: movesymlinkJoin
tobuild.package
#2874build.package
modules/output: movesymlinkJoin
tobuild.package
#2874Since this is experimental/draft, we don't need to tick off everything above before merging.