Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

4 restructure calibration compound #45

Merged
merged 22 commits into from
Sep 19, 2024
Merged

4 restructure calibration compound #45

merged 22 commits into from
Sep 19, 2024

Conversation

NRayya
Copy link
Contributor

@NRayya NRayya commented Sep 10, 2024

fixes #4

NRayya added 14 commits August 22, 2024 16:53
@NRayya
fix the hierarchy of the calibration compound branch
b0cd125
@NRayya
enhance definitions of the entities within the calibration compound b…
49bf465 
…ranch.
@NRayya
enhance the labels of the entities within calibration compound branch
1f84765
@NRayya
create the corresponding roles of the calibration compound branch
baf5eab
@NRayya
assign the roles for the calibration compound branch
28a058d
@NRayya
Add nucleus-based grouping classes from 2001 IUPAC recommendations
201a8aa
@NRayya
Add additional definition source to reference compounds
1d2c0f8
@NRayya
Add nucleus-based grouping classes from 2008 IUPAC recommendations.
2d5c247
@NRayya
adhere definitions to agreed upon conventions
1570278
@NRayya
deprecate children of concentration calibration compound
42310dc
@NRayya
minor fixes
7234e8e
@NRayya
Import IAO:0000140 setting datum
be3c4b6
@NRayya
Merge branch 'main' of https://github.com/nmrML/nmrCV into 4-restruct…
351fe25 
…ure-calibration-compound

# Conflicts:
#	src/ontology/nmrCV-edit.owl
@NRayya
Merge branch '43-import-setting-datum' of https://github.com/nmrML/nmrCV
2016efc 
 into 4-restructure-calibration-compound
@NRayya NRayya requested a review from StroemPhi September 10, 2024 12:32
@StroemPhi
Save as in Protégé to let OWL API autosort fix order
4494a2c 
needed due to search and replace change inhttps://github.com//pull/37/commits/9500cab19989a5801f7e170f0a14b23eadd2cc64
StroemPhi
StroemPhi requested changes Sep 19, 2024
View reviewed changes
Copy link
Contributor

@StroemPhi StroemPhi left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See my proposed changes regarding the wording of the compounds with roles.

src/ontology/nmrCV-edit.owl Outdated Show resolved Hide resolved
src/ontology/nmrCV-edit.owl Outdated Show resolved Hide resolved
src/ontology/nmrCV-edit.owl Outdated Show resolved Hide resolved
NRayya and others added 3 commits September 19, 2024 11:44
@NRayya @StroemPhi
Enhance wording
91fd23c 
Co-authored-by: Philip Strömert <[email protected]>
@NRayya @StroemPhi
Enhance wording
6d4ca51 
Co-authored-by: Philip Strömert <[email protected]>
@NRayya @StroemPhi
Enhance wording
92365cf 
Co-authored-by: Philip Strömert <[email protected]>
@NRayya NRayya requested a review from StroemPhi September 19, 2024 09:54
StroemPhi
StroemPhi reviewed Sep 19, 2024
View reviewed changes
src/ontology/nmrCV-edit.owl Outdated Show resolved Hide resolved
src/ontology/nmrCV-edit.owl Outdated Show resolved Hide resolved
src/ontology/nmrCV-edit.owl Outdated Show resolved Hide resolved
src/ontology/nmrCV-edit.owl Outdated Show resolved Hide resolved
NRayya and others added 4 commits September 19, 2024 12:31
@NRayya @StroemPhi
Adding NMR prefix to make the context of this role more clear.
544d238 
Co-authored-by: Philip Strömert <[email protected]>
@NRayya @StroemPhi
Adding NMR prefix to make the context of this role more clear
93cddea 
Co-authored-by: Philip Strömert <[email protected]>
@NRayya @StroemPhi
Adding NMR prefix to make the context of this role more clear
af582c3 
Co-authored-by: Philip Strömert <[email protected]>
@NRayya @StroemPhi
Add an annotation to the subclassOf axiom
6807abc 
We are injecting/adding classes of NMR calibration roles as we have more specialized classes than CHEBI

Co-authored-by: Philip Strömert <[email protected]>
@NRayya NRayya requested a review from StroemPhi September 19, 2024 10:49
@StroemPhi StroemPhi merged commit 46bed97 into main Sep 19, 2024
1 check passed
@StroemPhi StroemPhi deleted the 4-restructure-calibration-compound branch September 19, 2024 13:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StroemPhi StroemPhi StroemPhi approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Restructure calibration compound
2 participants
@NRayya @StroemPhi