-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[IR] Pretty-printer for LogicalObjectFifoFromMemrefOp #1017
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice addition!
I have a naming related request if it's okay - since we have tile assignment related pass/functionality, perhaps we make a difference (naming-wise) between a LOF that :-
- has not been assigned any tile.
- has been assigned with unknown tiles/tiles on different row and col.
memref<8xi32> -> !amdaie.logicalobjectfifo<memref<8xi32>> | ||
|
||
// logicalobjectfifo with a tile with a known column, unkown row: | ||
// CHECK: %lof_2_r_6 = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'd expect this to be %lof_2_r_0
or %lof_2_r_1
or %lof_2_r_2
instead %lof_2_r_6
- not sure where the last _6
is coming from.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let me explain and then improve!
Explanation: there is a %tile_0 and a %tile_1 before %lof_2_r_2, that's why it's starting at 2 not 0.
Improvement TODO: (1) tiles can have better suffixing (2) separate into 2+ lit tests.
compiler/plugins/target/AMD-AIE/iree-amd-aie/IR/test/roundtrip.mlir
Outdated
Show resolved
Hide resolved
memref<8xi32> -> !amdaie.logicalobjectfifo<memref<8xi32>> | ||
|
||
// logicalobjectfifo with a single unknown tile: | ||
// CHECK: %lof_2 = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Similarly I'd expect this as %lof_0
or %lof_1
?
Ok. I guess that would mean something like |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great!
844c980
to
af5474c
Compare
Makes IR easier to mentally parse -- it should be easier to figure out which columns/rows a
LogicalObjectFifoFromMemrefOp
is on.The lit tests have more examples