Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[AMDAIEControlCodeLowering] Separate DmaCpyNdToHalfDmaCpyNd to a new pass #945

Merged
merged 7 commits into from
Dec 2, 2024
Merged

[AMDAIEControlCodeLowering] Separate DmaCpyNdToHalfDmaCpyNd to a new pass #945

merged 7 commits into from
Dec 2, 2024

Conversation

Yu-Zhewen
Copy link
Contributor

@Yu-Zhewen Yu-Zhewen commented Nov 29, 2024 •
edited
Loading

  • Introduce a new pass that specifically handles the conversion of DmaCpyNd to HalfDmaCpyNd.
  • The remaining logic in ControlCodeLowering focuses on further lowering HalfDmaCpyNd into WriteBd, AddressPatch, and PushToQueue.
  • These changes are required for enabling DMA BD chaining Add a pass to chain DMA BDs #931

@Yu-Zhewen Yu-Zhewen changed the title Separate DmaToHalfDma from ControlCodeLowering [AMDAIEControlCodeLowering] Separate DmaCpyNdToHalfDmaCpyNd to a new pass Nov 29, 2024
jtuyls
jtuyls reviewed Nov 30, 2024
View reviewed changes
Copy link
Collaborator

@jtuyls jtuyls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Just a few small nits.

compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/test/controlcode_lowering.mlir Outdated Show resolved Hide resolved
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/test/controlcode_lowering.mlir Show resolved Hide resolved
compiler/plugins/target/AMD-AIE/iree-amd-aie/Transforms/test/npu_dma_to_half_dma_cpy_nd.mlir Outdated Show resolved Hide resolved
jtuyls
jtuyls approved these changes Dec 2, 2024
View reviewed changes
Copy link
Collaborator

@jtuyls jtuyls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Yu-Zhewen Yu-Zhewen enabled auto-merge (squash) December 2, 2024 13:13
@Yu-Zhewen Yu-Zhewen merged commit 0509e40 into main Dec 2, 2024
8 checks passed
@Yu-Zhewen Yu-Zhewen deleted the zhewen_separate_halfdma branch December 2, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtuyls jtuyls jtuyls approved these changes

@MaheshRavishankar MaheshRavishankar Awaiting requested review from MaheshRavishankar MaheshRavishankar is a code owner

@nirvedhmeshram nirvedhmeshram Awaiting requested review from nirvedhmeshram nirvedhmeshram is a code owner

@yzhang93 yzhang93 Awaiting requested review from yzhang93 yzhang93 is a code owner

@Abhishek-Varma Abhishek-Varma Awaiting requested review from Abhishek-Varma Abhishek-Varma is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Yu-Zhewen @jtuyls