Only restore the http/https request when used. #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current coverage is
|
|
+1 |
| @@ -260,6 +258,7 @@ function mockRequest() { | |||
| * @param {Number} [delay], response delay time, default is 10. | |||
| */ | |||
| exports.http.request = function (url, data, headers, delay) { | |||
| getAgent(http).__sourceRequest = getAgent(http).request; | |||
| return _request.call(this, http, url, data, headers, delay); | |||
There was a problem hiding this comment.
If test call mock request twice, retore will be wrong.
There was a problem hiding this comment.
mmh... indeed. Although it's meaningless if user calls the mock request twice(because the later mock will override the previous one), unable to restore to the original one is unacceptable. Will update the PR.
|
Please add a test case for this change. |
|
+1 |
|
I will merge this in command line |
|
landed 3c1ed43 |
|
2.0.1 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for #24