Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fixed string conversion to utf8 vs binary (closes #563) #564

Merged
merged 2 commits into from
Nov 30, 2023
Merged

fix: fixed string conversion to utf8 vs binary (closes #563) #564

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55611b2
fix: fixed string conversion to uf8 vs binary (closes #563)
titanism Nov 26, 2023
a8fbe83
fix: update imap composer for `compiled` types
titanism Nov 27, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 11 additions & 1 deletion imap-core/lib/imap-composer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,7 +60,17 @@ class IMAPComposer extends Transform {
);
}

this.push(Buffer.from(compiled + '\r\n', 'binary'));
// <https://github.com/nodemailer/wildduck/issues/563>
// <https://github.com/nodemailer/wildduck/pull/564
if (typeof compiled === 'object') {
this.push(compiled);
this.push('\r\n');
} else if (typeof compiled === 'string') {
this.push(Buffer.from(compiled + '\r\n', 'binary'));
} else {
return done(new TypeError('"compiled" was not an object or string'));
}

done();
}

Expand Down
Loading