-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Complete GCP namespace support #7836
Open
Neon-White
wants to merge
14
commits into
noobaa:master
Choose a base branch
from
Neon-White:implement-gcp-ns
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Neon-White
force-pushed
the
implement-gcp-ns
branch
from
February 21, 2024 09:13
2aea9d0
to
1d8bd81
Compare
Neon-White
force-pushed
the
implement-gcp-ns
branch
2 times, most recently
from
March 4, 2024 16:36
a89dccb
to
4522b53
Compare
shirady
reviewed
Mar 5, 2024
Neon-White
force-pushed
the
implement-gcp-ns
branch
3 times, most recently
from
March 13, 2024 09:26
e7d6cea
to
13dfda0
Compare
Neon-White
force-pushed
the
implement-gcp-ns
branch
from
March 19, 2024 09:18
13dfda0
to
93cf515
Compare
Neon-White
force-pushed
the
implement-gcp-ns
branch
from
March 27, 2024 22:39
84a7178
to
175cac3
Compare
Neon-White
force-pushed
the
implement-gcp-ns
branch
from
March 28, 2024 12:12
ec8835e
to
7eeb771
Compare
Neon-White
force-pushed
the
implement-gcp-ns
branch
from
April 8, 2024 08:26
2c1716a
to
1dc47c5
Compare
Neon-White
force-pushed
the
implement-gcp-ns
branch
3 times, most recently
from
May 7, 2024 00:01
6547d9b
to
7f71f4c
Compare
Neon-White
force-pushed
the
implement-gcp-ns
branch
from
May 8, 2024 15:19
7f71f4c
to
933d3e4
Compare
Neon-White
force-pushed
the
implement-gcp-ns
branch
from
May 16, 2024 08:55
78c3acf
to
0e3525a
Compare
Signed-off-by: Ben <[email protected]>
Signed-off-by: Ben <[email protected]>
Signed-off-by: Ben <[email protected]>
Signed-off-by: Ben <[email protected]>
Signed-off-by: Ben <[email protected]>
Signed-off-by: Ben <[email protected]>
Signed-off-by: Ben <[email protected]>
Signed-off-by: Ben <[email protected]>
Signed-off-by: Ben <[email protected]>
- Fix invalid call to stats collector Signed-off-by: Ben <[email protected]>
- Explain why an S3 client is used Signed-off-by: Ben <[email protected]>
Signed-off-by: Ben <[email protected]>
Signed-off-by: Ben <[email protected]>
- Remove `else` branch by adding an early exit Signed-off-by: Ben <[email protected]>
Neon-White
force-pushed
the
implement-gcp-ns
branch
from
May 29, 2024 11:24
2c6f02c
to
21966be
Compare
This PR had no activity for too long - it will now be labeled stale. Update it to prevent it from getting closed. |
Keep active... |
This PR had no activity for too long - it will now be labeled stale. Update it to prevent it from getting closed. |
Not today, github-actions <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
I opted to use AWS SDK v3 for posterity, and went with barebones commands to speed things up a bit,
Issues: Fixed #xxx / Gap #xxx
Testing Instructions:
I tested the PR locally with multipart uploads, as well as addition and removal of object metadata