PR1 - To install and upgrade noobaa version for running the tests #8517
Conversation
achouhan09
force-pushed
the
upgrade-tests
branch
8 times, most recently
from
1032b01 to
15a23fc
Compare
achouhan09
force-pushed
the
upgrade-tests
branch
from
15a23fc to
3f4cf92
Compare
achouhan09
changed the title
achouhan09
force-pushed
the
upgrade-tests
branch
from
3f4cf92 to
8515ca8
Compare
achouhan09
force-pushed
the
upgrade-tests
branch
from
8515ca8 to
e496520
Compare
achouhan09
force-pushed
the
upgrade-tests
branch
from
e496520 to
fc33e4d
Compare
achouhan09
force-pushed
the
upgrade-tests
branch
from
fc33e4d to
e762822
Compare
achouhan09
force-pushed
the
upgrade-tests
branch
from
e762822 to
f6b0289
Compare
achouhan09
force-pushed
the
upgrade-tests
branch
4 times, most recently
from
9fcd6af to
7808b68
Compare
| --db-resources='{ "limits": {"cpu": "200m","memory": "2G"}, "requests": {"cpu": "200m","memory": "2G"}}' \ | ||
| --core-resources='{ "limits": {"cpu": "200m","memory": "1G"}, "requests": {"cpu": "200m","memory": "1G"}}' \ | ||
| --endpoint-resources='{ "limits": {"cpu": "200m","memory": "1G"}, "requests": {"cpu": "200m","memory": "1G"}}' \ | ||
| --noobaa-image='noobaa-core:${{ env.BRANCH_NAME || 'master' }}' |
There was a problem hiding this comment.
In the step you wrote: "Install noobaa system (from master)" - did you mean master in the core repo, right? Then why --noobaa-image='noobaa-core:${{ env.BRANCH_NAME || 'master' }}'? I think it should be noobaa-core:upgrade-tests (which according to the steps represents "Build noobaa (latest)".
Are you sure the system should be installed in the latest version?
There was a problem hiding this comment.
I have also added pull request referece in latest build (in step 4) in my last commit, it would work I think.
There was a problem hiding this comment.
Removed the pull request reference as we don't need it I can see the latest code logs inside the upgrade tests pipeline, this proves that we checked out to latest code. Thanks
There was a problem hiding this comment.
I think I still don't understand it - I think that the title should be updated "Install noobaa system (from master)" It is not from master as we passed --noobaa-image='noobaa-core:${{ env.BRANCH_NAME || 'master' }}'
achouhan09
force-pushed
the
upgrade-tests
branch
2 times, most recently
from
ddd44ab to
5719ee6
Compare
.github/workflows/upgrade-tests.yaml
Outdated
| @@ -1,5 +1,5 @@ | |||
| name: Upgrade Tests | |||
| on: [push, pull_request, workflow_dispatch] | |||
| on: [pull_request] | |||
There was a problem hiding this comment.
No need of it, removed. thanks
|
@achouhan09 I see the last run failed (link). |
Signed-off-by: Aayush Chouhan <[email protected]>
Signed-off-by: Aayush Chouhan <[email protected]>
Signed-off-by: Aayush Chouhan <[email protected]>
Signed-off-by: Aayush Chouhan <[email protected]>
achouhan09
force-pushed
the
upgrade-tests
branch
from
5719ee6 to
c8150a4
Compare
| cd ./noobaa-core | ||
| make noobaa NOOBAA_TAG=noobaa-core:${{ env.BRANCH_NAME || 'master' }} | ||
|
|
||
| - name: Checkout noobaa-core (latest) |
There was a problem hiding this comment.
I think "latest" might be confusing - as it is according to the branch that was set in the input, right?
| --db-resources='{ "limits": {"cpu": "200m","memory": "2G"}, "requests": {"cpu": "200m","memory": "2G"}}' \ | ||
| --core-resources='{ "limits": {"cpu": "200m","memory": "1G"}, "requests": {"cpu": "200m","memory": "1G"}}' \ | ||
| --endpoint-resources='{ "limits": {"cpu": "200m","memory": "1G"}, "requests": {"cpu": "200m","memory": "1G"}}' \ | ||
| --noobaa-image='noobaa-core:${{ env.BRANCH_NAME || 'master' }}' |
There was a problem hiding this comment.
I think I still don't understand it - I think that the title should be updated "Install noobaa system (from master)" It is not from master as we passed --noobaa-image='noobaa-core:${{ env.BRANCH_NAME || 'master' }}'
| - name: Wait for phase Ready in the backingstore pod | ||
| run: | | ||
| cd ./noobaa-operator | ||
| ./.travis/number_of_pods_in_system.sh --pods 5 |
There was a problem hiding this comment.
I'm not sure we still need this.
In PR #7237 I mentioned that:
Run a script to wait until we have the backingstore pod (in k8s we cannot wait for a resource that doesn't exist (more information kubernetes/kubectl#1516, based on the change we did in noobaa/noobaa-operator#1063).
But it was on March 2023 and since that time I think the issue was closed with a solution that we can use.
Anyway, in version 4.19 the number of pods would probably change, so better avoid it if we can.
Explain the changes
Testing Instructions: