NSFS | set supplemental groups dynamically to users groups #8687
+122
−10
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explain the changes
Issues: Fixed #xxx / Gap #xxx
Testing Instructions:
sudo node ./node_modules/mocha/bin/mocha src/test/unit_tests/test_nsfs_access.js
GAPS
not implemented for mac - since all functions used are defined by posix it should be the same. but still require testing
also added helper testing functions for adding new group that require implementation for mac. should probably be done with
sudo dscl .
like adding new user, but again need to test this