Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Heightgraph in lieu of Elevation to show the elevation profile #345

Merged
merged 21 commits into from
Dec 23, 2020
Merged

Use Heightgraph in lieu of Elevation to show the elevation profile #345

Show file tree
Hide file tree
Changes from 12 commits
Commits
Show all changes
21 commits
Select commit Hold shift + click to select a range
840f4da
Use Heightgraph in lieu of Elevation
Sep 28, 2020
c17e6ed
Use Heightgraph in lieu of Elevation (part II)
Oct 11, 2020
37a0f9b
Use Heightgraph in lieu of Elevation (part III)
Oct 11, 2020
8fcec8e
Use Heightgraph in lieu of Elevation (part IV)
Oct 12, 2020
5fd3977
Use Heightgraph in lieu of Elevation (part V)
Oct 12, 2020
77ed28c
Use Heightgraph transpiled
Oct 23, 2020
bd0679d
Fix conflicts in Heightgraph integration
Oct 24, 2020
75b68eb
add comments; clean up
Oct 26, 2020
0adc28d
normalize gradient
Oct 26, 2020
73ad89e
improvements to gradient normalization
Oct 27, 2020
6b5912e
clean up; prod ready
Oct 27, 2020
dff71c5
clarify comment
Oct 27, 2020
0005752
Redo the Heightgraph patch as IIFE
Nov 3, 2020
6bb769c
Handle undefined altitude coordinate on latLng points
Nov 3, 2020
0fd13b0
Testing...
Nov 3, 2020
dd3c992
More testing...
Nov 4, 2020
0a67545
Clean up logging
Nov 4, 2020
f1d2855
Add back the collapse/expand and resize improvements
Nov 5, 2020
d83fddd
Set elevation on points without it (workaround for bug in Leaflet.Hei…
Nov 11, 2020
63d080d
Move the GeoJSON building functionality into separate module, and ref…
alexcojocaru Dec 21, 2020
3c1f5d0
Merge remote-tracking branch 'upstream/master' into heightgraph-trans…
alexcojocaru Dec 22, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions css/style.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -743,3 +743,15 @@ table.dataTable.display tbody tr:hover.selected {
so we ignore pointer events in this situation to avoid that*/
pointer-events: none;
}

/*
* Heightgraph customizations;
* since the legend and the gradient types are in the way, hide them;
* since there's only the gradient layer, hide the layer selector.
*/
.legend-hover {
display: none;
}
#selectionText {
display: none;
}
9 changes: 2 additions & 7 deletions js/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,8 @@
} else {
stats = new BR.TrackStats();
}
elevation = new BR.Elevation();

elevation = new BR.Heightgraph();

profile = new BR.Profile();
profile.on('update', function(evt) {
Expand Down Expand Up @@ -419,12 +420,6 @@
},
urlHash
);

// listener and initCollapse here and not in onAdd, as addBelow calls addTo (-> onAdd) on resize
$(window).resize(function() {
elevation.addBelow(map);
});
elevation.initCollapse(map);
}

i18next.on('languageChanged', function(detectedLanguage) {
Expand Down
116 changes: 0 additions & 116 deletions js/plugin/Elevation.js
View file
Open in desktop

This file was deleted.

Loading