-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add message if no elevation data is available #373
Conversation
I would find it nice if there were also a message for partly missing elevation data, e.g. if a route is only half in the no-data-zone, and for cases like in abrensch/brouter#137, i.e. the check would be for one or more undefined |
My personal opinion is, that any kind of interpolation is just an assumption and might be completely wrong, so I implemented gaps on purpose, see also GIScience/Leaflet.Heightgraph#108. For me, a simple message to inform about partly (or all) missing data, so gaps are not interpreted as mistake, is completely fine. |
As far as I know, it is BRouter engine that gives use waypoints altitude. If you do a route from A (no altitude known) to B (altitude known), BRouter will send a list of points without altitude, then some with altitude. While I could detect the first situation easily, the second one cannot be detected easily (except by patching BRouter to add a property). Any thoughts @nrenner? What would you suggest? PS: I cannot check for points above the 60°N 10°E-30°E limit, because there are other places on Earth where elevation data is missing (for instance here) |
When BRouter interpolates we can't do anything. I was more thinking about examples where BRouter doesn't, because data is missing at the start of a segment, e.g. your via on bridge example. My idea was simply to check if any But thinking about it, it doesn't look as broken as when there is no data at all, and it shows |
* upstream/master: Update France Go area to 10km Update bootstrap-select dep to avoid error on mobile Improve modal dialogs consistency Rename dialog Make modals fullscreen on mobile Hide expand icon on moblie (nrenner#296) Gray out unselectable layers (nrenner#381) Update translations Translate overlay type and fix width computation (nrenner#379) Use plural form when multiple overlays are active (nrenner#378) Add message if no elevation data is available (nrenner#373) Add missing translatable content (nrenner#376) Remove debug code Update translations Add What's new modal (nrenner#372) Add Babel and core-js & regenerator polyfills (nrenner#367)
Fix #365