Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow users to edit their own profiles #289

Merged
merged 3 commits into from
Mar 28, 2024
Merged

Allow users to edit their own profiles #289

merged 3 commits into from
Mar 28, 2024

Conversation

Hira-Ijaz
Copy link
Contributor

@Hira-Ijaz Hira-Ijaz commented Mar 27, 2024 •
edited by github-actions bot
Loading

Resolves #288

  • In the @user_bp.route('/<user_id>', POST) endpoint, added logic to allow users to edit their profiles

📚 Documentation preview 📚: https://usaon-benefit-tool--289.org.readthedocs.build/en/289/

mfisher87
mfisher87 reviewed Mar 27, 2024
View reviewed changes
Copy link
Contributor

@mfisher87 mfisher87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

❤️ Thanks so much for the PR! I'm not sure about the conditional. When you edit another user's profile as a non-admin, that is intended to fail, but I think with this conditional it would work. What are you observing when you test?

@Hira-Ijaz
Copy link
Contributor Author

❤️ Thanks so much for the PR! I'm not sure about the conditional. When you edit another user's profile as a non-admin, that is intended to fail, but I think with this conditional it would work. What are you observing when you test?

Thank you for pointing that out. You're correct; the current conditional might allow a non-admin user to edit another user's profile.

@Hira-Ijaz Hira-Ijaz requested a review from mfisher87 March 28, 2024 00:15
mfisher87
mfisher87 suggested changes Mar 28, 2024
View reviewed changes
usaon_benefit_tool/routes/user.py Outdated Show resolved Hide resolved
@Hira-Ijaz @mfisher87
Remove admin role check
b59f981 
Co-authored-by: Matt Fisher <[email protected]>
@Hira-Ijaz Hira-Ijaz requested a review from mfisher87 March 28, 2024 00:47
@mfisher87
Copy link
Contributor

Thanks so much for your contribution, @Hira-Ijaz !

@mfisher87 mfisher87 merged commit f9520a5 into nsidc:main Mar 28, 2024
5 checks passed
@mfisher87 mfisher87 changed the title Allow users to edit their profiles Allow users to edit their own profiles Mar 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mfisher87 mfisher87 mfisher87 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Users can't edit their own profiles
2 participants
@Hira-Ijaz @mfisher87