NXDRIVE-2711: Show that upload is still alive for very large files

nxdrive/gui/view.py

@@ -356,8 +356,7 @@ def data(self, index: QModelIndex, role: int, /) -> Any:
         if role == self.TRANSFERRED:
             return self.psize(row["filesize"] * row["progress"] / 100)
         if role == self.FINALIZING_STATUS:
-            a = row.get("finalizing_status")
-            return a
+            return row.get("finalizing_status")
         return row[self.names[role].decode()]
 
     def setData(self, index: QModelIndex, value: Any, /, *, role: int = None) -> None:

tests/unit/conftest.py

@@ -1,7 +1,7 @@
 import os
 import shutil
 import time
-from typing import Optional
+from typing import Any, Callable, Optional
 from uuid import uuid4
 
 import pytest
@@ -13,9 +13,12 @@
 from nxdrive.dao.manager import ManagerDAO
 from nxdrive.engine.engine import Engine
 from nxdrive.engine.processor import Processor
+from nxdrive.gui.view import DirectTransferModel
 from nxdrive.manager import Manager
 from nxdrive.objects import DocPair, Upload
 from nxdrive.osi import AbstractOSIntegration
+from nxdrive.qt import constants as qt
+from nxdrive.qt.imports import QObject
 from nxdrive.updater.darwin import Updater
 from nxdrive.utils import normalized_path
 
@@ -148,6 +151,13 @@ def __init__(self, Remote):
         super().__init__(self, Remote)
 
 
+class MockDirectTransferModel(DirectTransferModel):
+    def __init__(
+        self, translate: Callable[..., Any], /, *, parent: QObject = None
+    ) -> None:
+        super().__init__(translate, parent=parent)
+
+
 @pytest.fixture()
 def engine_dao(tmp_path):
     dao = MockEngineDAO
@@ -219,3 +229,25 @@ def upload():
     upload.doc_pair = "test_file"
     upload.request_uid = str(uuid4())
     return upload
+
+
+@pytest.fixture()
+def direct_transfer_model():
+    direct_transfer_model = MockDirectTransferModel
+    direct_transfer_model.FINALIZING_STATUS = qt.UserRole + 13
+    direct_transfer_model.items = [
+        {
+            "uid": 1,
+            "name": "a.txt",
+            "filesize": 142936511610,
+            "status": "",
+            "engine": "51a2c2dc641311ee87fb...bfc0ec09fa",
+            "progress": 100.0,
+            "doc_pair": 1,
+            "remote_parent_path": "/default-domain/User...TestFolder",
+            "remote_parent_ref": "7b7886ea-5ad9-460d-8...1607ea0081",
+            "shadow": True,
+            "finalizing": True,
+        }
+    ]
+    return direct_transfer_model

tests/unit/test_client_uploader.py

@@ -5,6 +5,7 @@
 
 
 def test_link_blob_to_doc(baseuploader, upload, tmp_path):
+    """Test link blob to document functionality"""
     file = tmp_path / f"{uuid4()}.txt"
     file.write_bytes(b"content")
 

tests/unit/test_view.py

@@ -0,0 +1,27 @@
+from unittest.mock import Mock
+
+from nxdrive.gui.view import FileModel
+
+
+def test_foldersDialog():
+    def func():
+        return True
+
+    file_model = FileModel(func)
+    returned_val = file_model.add_files([{"key": "val"}])
+    assert not returned_val
+
+
+def test_set_progress(direct_transfer_model):
+    """Test the finalize state after 100% progress"""
+    action = {
+        "engine": "51a2c2dc641311ee87fb...bfc0ec09fa",
+        "doc_pair": 1,
+        "progress": "100",
+        "action_type": "Linking",
+        "finalizing_status": "Finalize the status",
+    }
+
+    direct_transfer_model.createIndex = Mock(return_value=1)
+    direct_transfer_model.setData = Mock()
+    direct_transfer_model.set_progress(direct_transfer_model, action)