NXDRIVE-2915: Translate Document type and container type labels on Direct Transfer popup #5129
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🧙 Sourcery has finished reviewing your pull request! Tips
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
We've reviewed this pull request using the Sourcery rules engine. If you would also like our AI-powered code review then let us know.
…rect Transfer popup
gitofanindya
force-pushed
the
wip-NXDRIVE-2915-Translate-Document-type-and-container-type-labels-on-Direct-Transfer-popup
branch
from
b85005a to
b6165ab
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5129 +/- ##
==========================================
+ Coverage 49.24% 52.09% +2.85%
==========================================
Files 94 96 +2
Lines 15699 16087 +388
==========================================
+ Hits 7731 8381 +650
+ Misses 7968 7706 -262
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…NXDRIVE-2915-Translate-Document-type-and-container-type-labels-on-Direct-Transfer-popup
…rect Transfer popup.
…rect Transfer popup updated translation files
…rect Transfer popup fixed styles
poojadaine
approved these changes
Aug 12, 2024
mr-shekhar
requested changes
Aug 13, 2024
nxdrive/gui/folders_dialog.py
Outdated
| self.containerTypeList.append(Translator.get("FOLDER")) | ||
| else: | ||
| if "Audio" in self.docTypeList: | ||
| self.docTypeList.remove("Audio") |
There was a problem hiding this comment.
Avoid using multiple conditions
…rect Transfer popup --fixed types
…NXDRIVE-2915-Translate-Document-type-and-container-type-labels-on-Direct-Transfer-popup
gitofanindya
force-pushed
the
wip-NXDRIVE-2915-Translate-Document-type-and-container-type-labels-on-Direct-Transfer-popup
branch
from
eb582a4 to
5895d7c
Compare
…rect Transfer popup --added testcase
gitofanindya
force-pushed
the
wip-NXDRIVE-2915-Translate-Document-type-and-container-type-labels-on-Direct-Transfer-popup
branch
from
5895d7c to
78601e5
Compare
…rect Transfer popup --
…NXDRIVE-2915-Translate-Document-type-and-container-type-labels-on-Direct-Transfer-popup
…rect Transfer popup --created new branch for fr and ja translation files
…NXDRIVE-2915-Translate-Document-type-and-container-type-labels-on-Direct-Transfer-popup
mr-shekhar
approved these changes
Sep 4, 2024
gitofanindya
deleted the
wip-NXDRIVE-2915-Translate-Document-type-and-container-type-labels-on-Direct-Transfer-popup
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NXDRIVE-2915: Translate Document type and container type labels on Direct Transfer popup