NXDRIVE-2942: Improve folder selection on Direct Transfer screen

nxdrive/constants.py

@@ -70,6 +70,8 @@
     errno.ERANGE,  # Result too large
 }
 
+QUERY_ENDPOINT = "/api/v1/search/lang/NXQL/execute?query="
+
 # OSError indicating the incapacity to do anything because of too long file name or deep tree
 LONG_FILE_ERRORS = {errno.ENAMETOOLONG}
 if WINDOWS:

nxdrive/gui/folders_model.py

@@ -1,5 +1,5 @@
 from logging import getLogger
-from typing import Iterator, List, Union
+from typing import Any, Iterator, List, Union
 
 from nuxeo.models import Document
 
@@ -97,29 +97,48 @@
 
     def enable(self) -> bool:
         """Allow to select the folder only if the user can effectively create documents inside."""
-        return (
-            "HiddenInCreation" not in self.doc.facets
-            and self.doc.type not in Options.disallowed_types_for_dt
-            and "AddChildren" in self.doc.contextParameters["permissions"]
-        )
+        try:
+            return (
+                "HiddenInCreation" not in self.doc.facets
+                and self.doc.type not in Options.disallowed_types_for_dt
+                and "AddChildren" in self.doc.contextParameters["permissions"]
+            )
+        except Exception:
+            return (
+                "HiddenInCreation" not in self.doc["facets"]
+                and self.doc["type"] not in Options.disallowed_types_for_dt
+                and "AddChildren" in self.doc["contextParameters"]["permissions"]
+            )
 
     def get_id(self) -> str:
         """The document's UID."""
-        return self.doc.uid
+        try:
+            return self.doc.uid
+        except Exception:
+            return self.doc["uid"]
 
     def get_label(self) -> str:
         """The document's name as it is showed in the tree."""
-        return self.doc.title
+        try:
+            return self.doc.title
+        except Exception:
+            return self.doc["title"]
 
     def get_path(self) -> str:
         """Guess the document's path on the server."""
-        return self.doc.path
+        try:
+            return self.doc.path
+        except Exception:
+            return self.doc["path"]
 
     def selectable(self) -> bool:
         """Allow to fetch its children only if the user has at least the "Read" permission
         and if it contains at least one subfolder.
         """
-        return "Read" in self.doc.contextParameters["permissions"]
+        try:
+            return "Read" in self.doc.contextParameters["permissions"]
+        except Exception:
+            return "Read" in self.doc["contextParameters"]["permissions"]
 
 
 class FilteredDoc(FileInfo):
@@ -213,10 +232,12 @@
 
     def __init__(self, remote: Remote, /) -> None:
         self.remote = remote
+        self.personal_space_uid = ""
 
     def get_personal_space(self) -> "Documents":
         """Retrieve the "Personal space" special folder."""
         personal_space = self.remote.personal_space()
+        self.personal_space_uid = personal_space.uid
 
         # Alter the title to use "Personal space" instead of "Firstname Lastname"
         personal_space.title = Translator.get("PERSONAL_SPACE")
@@ -247,18 +268,43 @@
                 )
             )
 
+    def get_roots(self) -> List[Any]:
+        from ..constants import QUERY_ENDPOINT
+
+        url = (
+            f"{QUERY_ENDPOINT}select * from Document WHERE ecm:mixinType = 'Folderish'"
+        )
+        return self.remote.client.request("GET", url).json()["entries"]
+
     def _get_root_folders(self) -> List["Documents"]:
         """Get root folders.
         Use a try...except block to prevent loading error on the root,
         else it will also show a loading error for the personal space.
         """
+        root_details = []
         try:
-            root = self.remote.documents.get(path="/")
-            return [Doc(doc) for doc in self._get_children(root.uid)]
+            roots = self.get_roots()
+            for root in roots:
+                if (
+                    root["type"] == "Folder"
+                    and root["uid"] != self.personal_space_uid
+                    and root["parentRef"] != self.personal_space_uid
+                ):
+                    doc = self.remote.fetch(
+                        root["uid"],
+                        enrichers=["permissions"],
+                    )
+                    if (
+                        "Write" in doc["contextParameters"]["permissions"]
+                        or "ReadWrite" in doc["contextParameters"]["permissions"]
+                        or "Everything" in doc["contextParameters"]["permissions"]
+                    ):
+                        yield Doc(doc)
         except Exception:
             log.warning("Error while retrieving documents on '/'", exc_info=True)
             context = {"permissions": [], "hasFolderishChild": False}
-            return [Doc(Document(title="/", contextParameters=context))]
+            root_details.append([Doc(Document(title="/", contextParameters=context))])
+        return root_details
 
     def get_top_documents(self) -> Iterator["Documents"]:
         """Fetch all documents at the root."""