Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NXDRIVE-2967: Upgrade the deprecated datetime adapter #5267

Conversation

gitofanindya
Copy link
Collaborator

No description provided.

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have skipped reviewing this pull request. We don't review packaging changes - Let us know if you'd like us to change this.

@gitofanindya gitofanindya force-pushed the wip-NXDRIVE-2967-upgrade-the-deprecated-datetime-adapter branch from 4a0ed9c to b92e91e Compare September 19, 2024 06:15
@gitofanindya gitofanindya force-pushed the wip-NXDRIVE-2967-upgrade-the-deprecated-datetime-adapter branch from b92e91e to 613e4cd Compare September 19, 2024 06:17
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 77.77778% with 2 lines in your changes missing coverage. Please review.

Project coverage is 50.58%. Comparing base (74fc14e) to head (ab66853).
Report is 32 commits behind head on master.

Files with missing lines Patch % Lines
nxdrive/engine/engine.py 50.00% 1 Missing ⚠️
nxdrive/engine/watcher/remote_watcher.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5267      +/-   ##
==========================================
+ Coverage   49.24%   50.58%   +1.33%     
==========================================
  Files          94       96       +2     
  Lines       15699    16109     +410     
==========================================
+ Hits         7731     8148     +417     
+ Misses       7968     7961       -7     
Flag Coverage Δ
functional 42.84% <66.66%> (+4.76%) ⬆️
integration 2.01% <0.00%> (-0.06%) ⬇️
unit 38.65% <77.77%> (+1.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@gitofanindya gitofanindya changed the base branch from wip-NXDRIVE-2929-upgrade-python-from-3.9.5-to-3.12.3 to master September 24, 2024 06:14
@gitofanindya gitofanindya deleted the wip-NXDRIVE-2967-upgrade-the-deprecated-datetime-adapter branch September 25, 2024 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants