ci: split core #1419
Merged
ci: split core #1419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octol
approved these changes
Oct 29, 2024
pronebird
force-pushed
the
am/split-core-ci
branch
from
0626617 to
7b81052
Compare
octol
reviewed
Oct 29, 2024
|
Seeing CI being tidied up always brings me joy :) |
pronebird
commented
Oct 29, 2024
There was a problem hiding this comment.
I share the feeling. We deserved that.
Reviewable status: 0 of 7 files reviewed, 1 unresolved discussion (waiting on @octol and @zaneschepke)
.github/workflows/ci-nym-vpn-core-linux.yml line 36 at r1 (raw file):
Previously, octol (Jon Häggblad) wrote…
I strongly suspect that we don't need triplet anymore, on any of the ci core workflows
About to remove it.
pronebird
commented
Oct 29, 2024
There was a problem hiding this comment.
Reviewable status: 0 of 8 files reviewed, 1 unresolved discussion (waiting on @octol and @zaneschepke)
.github/workflows/ci-nym-vpn-core-linux.yml line 36 at r1 (raw file):
Previously, pronebird (Andrej Mihajlov) wrote…
About to remove it.
Done.
octol
approved these changes
Oct 29, 2024
|
@zaneschepke please have a look, provide your feedback. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract Mac, iOS, Linux, Android workflows from core CI workflow into individual ones.
New workflows
Removed
This change is