Wait for account to be ready to connect #1486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
rokas-ambrazevicius,
neacsu,
zaneschepke,
doums and
pronebird
pronebird
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Reviewed 9 of 9 files at r1.
Reviewable status: all files reviewed (commit messages unreviewed), all discussions resolved (waiting on @doums, @neacsu, @rokas-ambrazevicius, and @zaneschepke)
|
Please fix CI issues |
I think iOS pipeline can be ignored. I'm breaking-repairing that at the moment. |
pronebird
approved these changes
Nov 6, 2024
There was a problem hiding this comment.
Thanks @doums for fixing outstanding issues in this PR. I have tested it on iOS app and it works great! 🎉
Reviewed 5 of 5 files at r2, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @doums, @neacsu, @rokas-ambrazevicius, and @zaneschepke)
zaneschepke
approved these changes
Nov 6, 2024
octol
added a commit
that referenced
this pull request
Nov 6, 2024
* Add wait_for_ready_to_connect and use in vpnd * Update error types * Switch uniffi start vpn to wait on ready to connect * Separate out account update command in uniffi API * Bump timeout to 10 sec * add the new error to nym-vpn-app * Update uniffi --------- Co-authored-by: pierre <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is