[Breaking change] Add conversions from proto to core types #1950
+348
−400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
rokas-ambrazevicius,
neacsu and
zaneschepke
pronebird
commented
Jan 17, 2025
| println!("{:#?}", response); | ||
| if response.status == nym_vpn_proto::ConnectionStatus::NotConnected as i32 { | ||
|
|
||
| let re = stream.message().await; |
There was a problem hiding this comment.
Well that's a leftover to remove
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fromconversions from proto toTunnelStateTunnelStateby converting some of the nym types intoStringnym-type-conversionsto remove dependendencies on nym crates when not needed.TunnelStatefrom grpc which is a breaking change and it will break desktop apps.Fromconversions instead of working with raw grpc types when reporting vpn status.This change is