Make API requests through nym-http-api-client #1951
+214
−176
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is intended to reduce (ideally to 0) the number of places that we are accessing the Nym API without using the
nym-http-api-client.There were only a handful of places that this was not already the case. While there is likely a more efficient refactor that could be done to better organize the API accesses and the resources that we build out of those accesses, that is not in the scope of this PR.
There is some slight awkwardness around the async / sync function calls here. I tried to keep the existing function signatures as they were which in some places meant using a block_on to call an async fn in a sync context.
This change is