Wrap search input in a form with role="search" so that right clicking gives "Add keyword for this search". #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… gives "Add keyword for this search".
|
Is there a reason this is still a draft? |
|
As I mentioned in my first comment, I suspect this messes up the behavior of searching without submitting the page. |
|
Does this being in the draft status mean that you'll test it out and continue working on it, or is it ready for review / should I test it? |
|
I suspect (largely based on evidence), that I'll not find time to work on this for a while, so feel free to do whatever with this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does correctly add the menu option, but I've not setup the toolchain to check if this messes up the behavior of searching without submitting the page; I suspect that it does not.