Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uses our Wayland event queue to construct WindowIdentifier #1228

Merged
merged 1 commit into from
Jan 5, 2025

Conversation

ultimaweapon
Copy link
Member

WindowIdentifier::from_raw_handle on Wayland always create a new set of global objects on the compositor on each invocation, which cause a memory to leak since those objects will be free only when the connection with compositor is closed.

@github-actions github-actions bot added the S-ready Status: Ready for review label Jan 5, 2025
@SuchAFuriousDeath SuchAFuriousDeath merged commit b6d26c9 into obhq:main Jan 5, 2025
6 checks passed
@ultimaweapon ultimaweapon deleted the wayland branch January 6, 2025 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-ready Status: Ready for review
Development

Successfully merging this pull request may close these issues.

2 participants