Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implements socket creation, initializes rng, gc and camera devices #819

Merged
merged 10 commits into from
Apr 11, 2024

Conversation

SuchAFuriousDeath
Copy link
Contributor

As I write in the doc comment for 'SocketBackend', the protocol implementation isn't exactly ideal and will probably change a lot before we settle on something. I consider it sufficient for now.

@SuchAFuriousDeath SuchAFuriousDeath requested a review from a team April 8, 2024 20:37
@github-actions github-actions bot added the S-ready Status: Ready for review label Apr 8, 2024
@SuchAFuriousDeath
Copy link
Contributor Author

SuchAFuriousDeath commented Apr 8, 2024

One has to commit a lot of programming war crimes to reach all of this.
Some things I skipped on the way include mmap_dmem, mprotect, munmap, mdb_service and clock_gettime.

About the rng algorithms: Once again, red-prig just uses arnd here, so it's probaly fine for us to use it as well, at least for now
About the socket ioctl: It's in-only, the socket is just opened, the ioctl is ran and the socket is closed and never seen again. I don't think we want to spend time on this.

@SuchAFuriousDeath SuchAFuriousDeath changed the title Implements sockets, initializes rng, gc and camera devices Implements socket creation, initializes rng, gc and camera devices Apr 8, 2024
Copy link
Member

@FluffyOMC FluffyOMC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Get reviewed (nerd)

src/kernel/src/dev/gc.rs Outdated Show resolved Hide resolved
mikusp
mikusp previously approved these changes Apr 11, 2024
@SuchAFuriousDeath SuchAFuriousDeath merged commit 81fa97a into obhq:main Apr 11, 2024
5 checks passed
@SuchAFuriousDeath SuchAFuriousDeath deleted the socket branch April 11, 2024 19:53
This was linked to issues Apr 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-ready Status: Ready for review
Development

Successfully merging this pull request may close these issues.

Implement /dev/rng Implement /dev/camera
3 participants